HCal: Fix calo sample precision data from SiPM hits

[lwang046]

PR description:

A small fix to the hcal simulated calo sample precision data. Each precise bin represents charge in 0.5 ns instead of 1 ns.
This change will affect the precise pulse shape of the calosample which is used in TDC simulation, thus we should expect changes in TDC related histograms.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29235/14263

• This PR adds an extra 16KB to repository

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5263/console Started: 2020/03/18 23:34

[cmsbuild]

A new Pull Request was created by @lwang046 for master.

It involves the following packages:

SimCalorimetry/HcalSimAlgos

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@mariadalfonso, @rovere this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 3c7ba4d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5efca/5263/summary.html
CMSSW: CMSSW_11_1_X_2020-03-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5efca/5263/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692437
• DQMHistoTests: Total failures: 126
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2691992
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

@lwang046 , can you, please, make a reference to the talk or to a plot in PR description. Have you any explanation for 126 differences in regression?

[abdoulline]

@civanch
Vladimir, those DQM differences come solely from TDC-related plots for 2018/2021/2023/2026 wf's. That's the exactly what the fix is supposed to do.
We've had our internal investigation and tracked down the issue of precision samples charge discrepancy wrt regular CaloSamples, which is now fixed by this PR.
TDC simulation uses precision samples, so it (and only it) is affected.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1