Update relvals of JME customised Nano for 2016,17,18

[srimanob]

PR description:

This is an update on top of #28857 to cover 2017, 2018 MCs

• workflow: pileup 25202.15 (was 25202.01) for 2016 MC
• workflow: upgrade 10224.15 (or any 2017 workflows) for 2017 MC
• workflow: upgrade 11024.15 (or any 2018 workflows) for 2018 MC

PR validation:

local runs with above workflows are OK.

if this PR is a backport please specify the original PR and why you need to backport that PR:

FYI @nurfikri89

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29279/14334

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @pgunnell, @kpedro88, @zhenhu can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[chayanit]

please test workflow 25202.15,10224.15,11024.15

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 11024.15,10224.15,25202.15
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5341/console Started: 2020/03/24 05:23

[cmsbuild]

-1

Tested at: 969414a

CMSSW: CMSSW_11_1_X_2020-03-23-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03c693/5341/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[srimanob]

@chayanit
From the log,
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03c693/5341/runTheMatrix-results/matrixTests.log

I think I may need to define the upgrade test workflow in relval_2017 first before you can trigger the test on upgrade workflow.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03c693/5448/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-03c693/10224.15_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_JMENano_2017PU
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-03c693/11024.15_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018PU_GenSimFull+DigiFullPU_2018PU+RecoFullPU_2018PU+HARVESTFullPU_2018PU+NanoFull_JMENano_2018PU
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-03c693/25202.15_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692110
• DQMHistoTests: Total failures: 57
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2691734
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[kpedro88]

+upgrade

[chayanit]

+1

[srimanob]

@peruzzim
There is a tiny modification on JME customization in NanoAOD, just to return the updated process. Could you please check? Thanks.

[santocch]

+1

[silviodonato]

do you have comments @fgolf @peruzzim ?

[silviodonato]

@fgolf @peruzzim I'm going to integrate this PR before the next IB. Please let me know if you have any objection

[peruzzim]

+xpog

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1