Make some HLT modules into global modules

[Dr15Jones]

PR description:

Changed the following modules to be global modules

• ScalersRawToDigi
• TriggerSummaryAnalyzerAOD
• TriggerSummaryAnalyzerRAW
• TriggerSummaryProducerAOD
• TriggerSummaryProducerRAW

PR validation:

The code compiles. I did do scram b runtests and no error was reported.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29301/14366

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29301/14366/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29301/14366/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29301/14367

• This PR adds an extra 28KB to repository

[Dr15Jones]

I noticed these modules when looking at Tracer output from #29209. These modules were being called on stream Lumi and Run transitions even though they did not care about them (because they were stream modules). Making them global reduces the number of modules called on those transitions.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

EventFilter/ScalersRawToDigi
HLTrigger/HLTcore

@perrotta, @cmsbuild, @fwyzard, @Martin-Grunewald, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5377/console Started: 2020/03/25 15:38

[cmsbuild]

-1

Tested at: 46a7cec

CMSSW: CMSSW_11_1_X_2020-03-25-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fed04b/5377/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

Entering library rule at ElectroWeakAnalysis/WENu
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-03-25-1100/src/ElectroWeakAnalysis/WENu/src/WenuPlots.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-03-25-1100/src/ElectroWeakAnalysis/WENu/src/GenPurposeSkimmerData.cc 
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-03-25-1100/src/ElectroWeakAnalysis/WENu/interface/GenPurposeSkimmerData.h:25,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-03-25-1100/src/ElectroWeakAnalysis/WENu/src/GenPurposeSkimmerData.cc:46:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-03-25-1100/poison/HLTrigger/HLTcore/interface/TriggerSummaryAnalyzerAOD.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-03-25-1100/src/ElectroWeakAnalysis/WENu/interface/GenPurposeSkimmerData.h:25,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-03-25-1100/src/ElectroWeakAnalysis/WENu/src/GenPurposeSkimmerData.cc:46:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-03-25-1100/poison/HLTrigger/HLTcore/interface/TriggerSummaryAnalyzerAOD.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.


[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5437/console Started: 2020/03/30 16:56

[Dr15Jones]

I restarted the tests to see if the number of failures will decrease now that other pull requests have been used in the IBs.

[cmsbuild]

+1
Tested at: 47a4b8f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fed04b/5437/summary.html
CMSSW: CMSSW_11_1_X_2020-03-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fed04b/5437/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692110
• DQMHistoTests: Total failures: 35
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2691756
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[Martin-Grunewald]

+1

[santocch]

+1

[perrotta]

+1

• Technical
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1