Fix TaskPlaceholder dumpPython method

[rovere]

PR description:

While developing some utility, I stumble upon what I think is a bug that I fix with this PR.
Removing "white space" differences will help spot the bug and the fix.

PR validation:

I'm not sure how to properly test it. I run it within an interactive python session and it seems to solve the issue.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29327/14399

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

FWCore/ParameterSet

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

Thanks @rovere! Apparently SequencePlaceholder has the same problem

cmssw/FWCore/ParameterSet/python/SequenceTypes.py

Lines 711 to 715 in d07efe6

	def dumpPython(self, options=PrintOptions()):
	result = 'cms.SequencePlaceholder(\"'
	if options.isCfg:
	result += 'process.'
	result += +self._name+'\")\n'

Would you mind fixing that as well on the same go?

There are tests at the end of the file

cmssw/FWCore/ParameterSet/python/SequenceTypes.py

Lines 1640 to 1641 in d07efe6

	if __name__=="__main__":
	import unittest

but I see none for TaskPlaceholder or SequencePlaceholder. Could you add simple tests e.g. at the end of in this function

cmssw/FWCore/ParameterSet/python/SequenceTypes.py

Line 1738 in d07efe6

def testDumpPython(self):

?

[cmsbuild]

The code-checks are being triggered in jenkins.

[rovere]

Ciao @makortel
I fixed also the SequencePlaceholder and implemented the unit-tests.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29327/14413

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #29327 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

[makortel]

Thanks!

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5433/console Started: 2020/03/30 14:42

[cmsbuild]

+1
Tested at: 82c03b3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aaf497/5433/summary.html
CMSSW: CMSSW_11_1_X_2020-03-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aaf497/5433/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692110
• DQMHistoTests: Total failures: 34
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2691757
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1