Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix miniaod_devel modifier use for pileupJetId.algos #29377

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Apr 2, 2020

similar to #29376:

a problem was observed when testing re-mini and nano workflows with run2_miniAOD_devel: there is no support in process modifiers toReplaceWith for a VPset.
This PR fixes the problem.

Tested on 136.8311 and 1325.7 modified to also use run2_miniAOD_devel

This is a fix to the backport of #28984 made in #29045

@cmsbuild cmsbuild added this to the CMSSW_10_6_X milestone Apr 2, 2020
@slava77
Copy link
Contributor Author

slava77 commented Apr 2, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_10_6_X.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @jdamgov, @yslai, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Apr 2, 2020

@cmsbuild please abort test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

Jenkins tests are aborted.

@slava77 slava77 force-pushed the CMSSW_10_6_X_2020-04-01-2300/sign1097pre/fixPUID branch from 56405bb to 2514331 Compare April 2, 2020 05:38
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

Pull request #29377 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor Author

slava77 commented Apr 2, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5496/console Started: 2020/04/02 09:09

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

+1
Tested at: 2514331
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e8559/5496/summary.html
CMSSW: CMSSW_10_6_X_2020-04-01-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e8559/5496/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 20
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211970
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor Author

slava77 commented Apr 2, 2020

+1

for #29377 2514331

  • since this affects only a setup with run2_miniAOD_devel modifier, the fix is tested locally, as in the PR description
  • regular jenkins tests pass and comparisons show no (relevant) differences

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1762faf into cms-sw:CMSSW_10_6_X Apr 2, 2020
@slava77 slava77 mentioned this pull request Apr 17, 2020
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants