Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr11x L1T Configure EMTF using stage2L1Trigger modifiers #29413

Merged
merged 1 commit into from Apr 13, 2020

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Apr 8, 2020

PR description:

Configure EMTF using eras stage2L1Trigger, stage2L1Trigger_2017, stage2L1Trigger_2018.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29413/14574

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/L1TMuonEndCap

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Apr 8, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5589/console Started: 2020/04/08 12:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

+1
Tested at: 6cc2cb1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-140910/5589/summary.html
CMSSW: CMSSW_11_1_X_2020-04-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-140910/5589/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692110
  • DQMHistoTests: Total failures: 84
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691707
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Apr 13, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6cd815f into cms-sw:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants