Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move booking in the beginRun #2942

Merged
merged 1 commit into from
Mar 23, 2014
Merged

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Mar 20, 2014

move histograms booking in BR. this fixes a wrong behaviour that makes the jobs crashing when the DQMIO is used and the L1 menu changes from one run to another.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio for CMSSW_7_1_X.

move booking in the beginRun

It involves the following packages:

DQM/L1TMonitor

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor Author

deguio commented Mar 20, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Mar 21, 2014

@deguio don't you need to do some cleanup at endRun? (just asking)

@deguio
Copy link
Contributor Author

deguio commented Mar 23, 2014

@ktf
we discussed in person already. the answer is no. :)

ciao and thanks,
F.

davidlange6 added a commit that referenced this pull request Mar 23, 2014
@davidlange6 davidlange6 merged commit ab39b3d into cms-sw:CMSSW_7_1_X Mar 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants