Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated lost dictionaries mapping for L1T Phase2 #29475

Merged
merged 1 commit into from Apr 15, 2020
Merged

updated lost dictionaries mapping for L1T Phase2 #29475

merged 1 commit into from Apr 15, 2020

Conversation

smuzaffar
Copy link
Contributor

PR description:

#29348 introduced new dictionaries which are now wrongly mapped under CaloTowers ( https://cmssdt.cern.ch/SDT/cgi-bin/showDupDict.py//cc8_amd64_gcc8/www/tue/11.1-tue-23/CMSSW_11_1_X_2020-04-14-2300/testLogs/dupDict-lostDefs.log ). This PR proposes to update the dictionary mapping for L1T CalorimeterPhase2 (l1tp2) to be mapped under L1TCalorimeterPhase2

PR validation:

Locally built and ran duplicateReflexLibrarySearch.py --lostDefs

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29475/14679

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5698/console Started: 2020/04/15 09:36

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Utilities/ReleaseScripts

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

This is trivial and fix the failing QA dictionary checks.

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 743041a into cms-sw:master Apr 15, 2020
@cmsbuild
Copy link
Contributor

+1
Tested at: ea68522
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a5d08/5698/summary.html
CMSSW: CMSSW_11_1_X_2020-04-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a5d08/5698/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 40
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696076
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants