New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated lost dictionaries mapping for L1T Phase2 #29475
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29475/14679
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: Utilities/ReleaseScripts @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
This is trivial and fix the failing QA dictionary checks. |
merge |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
PR description:
#29348 introduced new dictionaries which are now wrongly mapped under CaloTowers ( https://cmssdt.cern.ch/SDT/cgi-bin/showDupDict.py//cc8_amd64_gcc8/www/tue/11.1-tue-23/CMSSW_11_1_X_2020-04-14-2300/testLogs/dupDict-lostDefs.log ). This PR proposes to update the dictionary mapping for L1T CalorimeterPhase2 (l1tp2) to be mapped under L1TCalorimeterPhase2
PR validation:
Locally built and ran
duplicateReflexLibrarySearch.py --lostDefs