-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete unscheduled modules that are not consumed by any scheduled module #29553
Commits on Oct 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 902039b - Browse repository at this point
Copy the full SHA 902039bView commit details -
Delete unscheduled modules whose products are not consumed by anything
The corresponding WorkerT continues to exist, but is removed from all WorkerManagers so that it does not get called for any transitions. The deleted modules are removed from PathsAndConsumesOfModules. Allow worker_ to be nullptr in UnscheduledProductResolver, can happen if a module is deleted early. The Worker::description() returns now nullptr if module was deleted. The description() is not expected to be called when the module is deleted, so this change is mostly a safety check in the hope of getting a segfault if the nullptr is accessed.
Configuration menu - View commit details
-
Copy full SHA for d16fc6a - Browse repository at this point
Copy the full SHA d16fc6aView commit details -
Delete non-consumed unscheduled modules in SubProcessses
Need to pass module label and process name for consumes of products of parent (sub)process(es).
Configuration menu - View commit details
-
Copy full SHA for 0c888f6 - Browse repository at this point
Copy the full SHA 0c888f6View commit details -
Keep Accumulator modules running by adding data dependencies in globa…
…l/stream/limited/one tests
Configuration menu - View commit details
-
Copy full SHA for 3795ad1 - Browse repository at this point
Copy the full SHA 3795ad1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29d29dc - Browse repository at this point
Copy the full SHA 29d29dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1c17df - Browse repository at this point
Copy the full SHA e1c17dfView commit details -
Keep modules in non-event ordering unit tests running by moving the l…
…ast one in the chain to a Path Without a scheduled module consuming their output all modules would be deleted.
Configuration menu - View commit details
-
Copy full SHA for 61dd9db - Browse repository at this point
Copy the full SHA 61dd9dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a41a17 - Browse repository at this point
Copy the full SHA 5a41a17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ab4449 - Browse repository at this point
Copy the full SHA 1ab4449View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c1a8a5 - Browse repository at this point
Copy the full SHA 1c1a8a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf39115 - Browse repository at this point
Copy the full SHA bf39115View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52799a9 - Browse repository at this point
Copy the full SHA 52799a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ac7ac9 - Browse repository at this point
Copy the full SHA 6ac7ac9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 381480e - Browse repository at this point
Copy the full SHA 381480eView commit details -
Configuration menu - View commit details
-
Copy full SHA for add0c31 - Browse repository at this point
Copy the full SHA add0c31View commit details -
Configuration menu - View commit details
-
Copy full SHA for a756679 - Browse repository at this point
Copy the full SHA a756679View commit details -
Configuration menu - View commit details
-
Copy full SHA for f26bf97 - Browse repository at this point
Copy the full SHA f26bf97View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb79bdb - Browse repository at this point
Copy the full SHA cb79bdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c41364 - Browse repository at this point
Copy the full SHA 1c41364View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb852dd - Browse repository at this point
Copy the full SHA bb852ddView commit details -
Rename module in non-event ordering tests to avoid accidental success
From David Dagenhart: > It is not at all obvious looking at it, but this change just > coincidentally happens to give the execution order 'a' then 'c' then > 'b'. Since the purpose of the test is to demonstrate the Framework > is forcing that execution order we should probably perturb this in > some way so it isn't just doing it by accident. Renaming 'a' to 'd' > seems to do the trick.
Configuration menu - View commit details
-
Copy full SHA for 8873e2b - Browse repository at this point
Copy the full SHA 8873e2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for eaac76f - Browse repository at this point
Copy the full SHA eaac76fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f77931e - Browse repository at this point
Copy the full SHA f77931eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 897ef77 - Browse repository at this point
Copy the full SHA 897ef77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c053f9 - Browse repository at this point
Copy the full SHA 9c053f9View commit details
Commits on Oct 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c38022d - Browse repository at this point
Copy the full SHA c38022dView commit details