Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unscheduled modules that are not consumed by any scheduled module #29553

Merged
merged 26 commits into from
Dec 2, 2020

Commits on Oct 1, 2020

  1. Configuration menu
    Copy the full SHA
    902039b View commit details
    Browse the repository at this point in the history
  2. Delete unscheduled modules whose products are not consumed by anything

    The corresponding WorkerT continues to exist, but is removed from all
    WorkerManagers so that it does not get called for any transitions. The
    deleted modules are removed from PathsAndConsumesOfModules.
    
    Allow worker_ to be nullptr in UnscheduledProductResolver, can happen
    if a module is deleted early.
    
    The Worker::description() returns now nullptr if module was deleted.
    The description() is not expected to be called when the module is
    deleted, so this change is mostly a safety check in the hope of
    getting a segfault if the nullptr is accessed.
    makortel committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    d16fc6a View commit details
    Browse the repository at this point in the history
  3. Delete non-consumed unscheduled modules in SubProcessses

    Need to pass module label and process name for consumes of products of
    parent (sub)process(es).
    makortel committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    0c888f6 View commit details
    Browse the repository at this point in the history
  4. Keep Accumulator modules running by adding data dependencies in globa…

    …l/stream/limited/one tests
    makortel committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    3795ad1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    29d29dc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e1c17df View commit details
    Browse the repository at this point in the history
  7. Keep modules in non-event ordering unit tests running by moving the l…

    …ast one in the chain to a Path
    
    Without a scheduled module consuming their output all modules would be deleted.
    makortel committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    61dd9db View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5a41a17 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1ab4449 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1c1a8a5 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    bf39115 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    52799a9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6ac7ac9 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    381480e View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    add0c31 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a756679 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    f26bf97 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    cb79bdb View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    1c41364 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    bb852dd View commit details
    Browse the repository at this point in the history
  21. Rename module in non-event ordering tests to avoid accidental success

    From David Dagenhart:
    > It is not at all obvious looking at it, but this change just
    > coincidentally happens to give the execution order 'a' then 'c' then
    > 'b'. Since the purpose of the test is to demonstrate the Framework
    > is forcing that execution order we should probably perturb this in
    > some way so it isn't just doing it by accident. Renaming 'a' to 'd'
    > seems to do the trick.
    makortel committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    8873e2b View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    eaac76f View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    f77931e View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    897ef77 View commit details
    Browse the repository at this point in the history
  25. code checks

    makortel committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    9c053f9 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Configuration menu
    Copy the full SHA
    c38022d View commit details
    Browse the repository at this point in the history