PUPPI tune v14 (phase-2 excluded) #29600

ahinzmann · 2020-04-30T12:32:53Z

PR description:

Followup on #28844.
Switch the master from PUPPI tune v11 to v14.
The handling of charged particles that FAIL track-vertex association by "used-in-fit" is changed to improve jet energy resolution at high pT. For those charged particles:

Fall-back to vertex association by dz is disabled in |eta|<2.4.
Charged particles with pT>20 are protected to never be rejected.

Also update customizer function for PUPPI tune V14 for backport to 10_6 for JME-extended-NanoAODs for UL.

PR validation:

Validation of the new tune is in the following presentations:
https://indico.cern.ch/event/905128/#35-update-on-puppi-v14
https://indico.cern.ch/event/901254/#3-ul17-puppi-v14-mc-jec
https://indico.cern.ch/event/913808/#4-updates-on-ul-17-mc-jec-for

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport to 10_6 to include into UL-reminiAOD.

cmsbuild · 2020-04-30T12:33:20Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-30T12:39:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29600/14936

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CommonTools/PileupAlgos/plugins/PuppiProducer.cc modified in PR(s): PUPPI MET in RECO #29254
- File CommonTools/PileupAlgos/plugins/PuppiProducer.h modified in PR(s): PUPPI MET in RECO #29254
- File CommonTools/PileupAlgos/python/Puppi_cff.py modified in PR(s): PUPPI MET in RECO #29254
- File CommonTools/PileupAlgos/python/customizePuppiTune_cff.py modified in PR(s): PUPPI MET in RECO #29254

cmsbuild · 2020-04-30T12:39:39Z

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

CommonTools/PileupAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @riga, @jdolen, @gkasieczka, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-04-30T12:40:08Z

please test

cmsbuild · 2020-04-30T12:40:34Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5932/console Started: 2020/04/30 14:43

cmsbuild · 2020-04-30T14:00:35Z

+1
Tested at: 096fae6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-408939/5932/summary.html
CMSSW: CMSSW_11_1_X_2020-04-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-04-30T14:00:38Z

Comparison job queued.

cmsbuild · 2020-04-30T15:30:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-408939/5932/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6063 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696239
DQMHistoTests: Total failures: 8866
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2687054
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

slava77 · 2020-05-02T15:37:12Z

On 5/2/20 6:29 AM, ahinzmann wrote: I don't find any Phase-2 plots in the comparisons or DQM. Can this be ran as well? It would good to run those tests as well, to make sure that the impact is small (by construction). —

it looks like this comment was edited away/deleted. 10 events without PU is not a lot to show a pattern for a tool aiming for PU subtraction.

perrotta · 2020-05-04T16:30:48Z

As @slava77 already pointed out, you did not provide comparisons for the Phase2 config.
The change is PtMaxCharged that goes from "-1" to "20", and PtMaxNeutralsStartSlope from "0" to "20": the effect is visible in the Phase2 jenkins tests outputs. Did you validate such update for the Phase2 config? If not, shouldn't it be more advisable to stick on the current settings?

cmsbuild · 2020-05-11T11:56:45Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-11T12:02:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29600/15277

This PR adds an extra 20KB to repository

cmsbuild · 2020-05-11T12:03:20Z

Pull request #29600 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

perrotta · 2020-05-11T12:32:41Z

please test

cmsbuild · 2020-05-11T12:33:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6218/console Started: 2020/05/11 14:43

cmsbuild · 2020-05-11T14:00:59Z

+1
Tested at: 6f15ade
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-408939/6218/summary.html
CMSSW: CMSSW_11_1_X_2020-05-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-11T14:01:03Z

Comparison job queued.

cmsbuild · 2020-05-11T15:36:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-408939/6218/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 5890 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2697527
DQMHistoTests: Total failures: 8517
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2688691
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

perrotta · 2020-05-11T16:48:50Z

+1

Move to Puppi tune v14 is applied to all Phase1 workflows,; not yet in Phase2, were the corresponding validation is still missing
Jenkins tests pass. Chenges are in line with the expectations, and validated independently in the JetMET POG

silviodonato · 2020-05-14T07:22:51Z

merge
FYI @santocch

santocch · 2020-05-14T12:32:54Z

+1

cmsbuild · 2020-05-14T12:33:19Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

puppi v14

096fae6

ahinzmann mentioned this pull request Apr 30, 2020

PUPPI tune v14 [10_6_X] #29601

Merged

cmsbuild added this to the CMSSW_11_1_X milestone Apr 30, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 30, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 30, 2020

cmsbuild added tests-started and removed tests-pending labels Apr 30, 2020

cmsbuild added tests-approved and removed tests-started labels Apr 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Apr 30, 2020

This was referenced May 6, 2020

Revert "PUPPI MET in RECO" #29748

Merged

PUPPI MET in RECO #29768

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels May 11, 2020

cmsbuild added tests-started and removed tests-pending labels May 11, 2020

cmsbuild added tests-approved and removed tests-started labels May 11, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 11, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels May 11, 2020

silviodonato changed the title ~~PUPPI tune v14~~ PUPPI tune v14 (phase-2 excluded) May 14, 2020

cmsbuild added orp-approved and removed orp-pending labels May 14, 2020

cmsbuild merged commit a1a39aa into cms-sw:master May 14, 2020

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels May 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PUPPI tune v14 (phase-2 excluded) #29600

PUPPI tune v14 (phase-2 excluded) #29600

ahinzmann commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

perrotta commented Apr 30, 2020

cmsbuild commented Apr 30, 2020 •

edited

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

slava77 commented May 2, 2020 via email

perrotta commented May 4, 2020 •

edited

cmsbuild commented May 11, 2020

cmsbuild commented May 11, 2020

cmsbuild commented May 11, 2020

perrotta commented May 11, 2020

cmsbuild commented May 11, 2020 •

edited

cmsbuild commented May 11, 2020

cmsbuild commented May 11, 2020

cmsbuild commented May 11, 2020

perrotta commented May 11, 2020

silviodonato commented May 14, 2020

santocch commented May 14, 2020

cmsbuild commented May 14, 2020

PUPPI tune v14 (phase-2 excluded) #29600

PUPPI tune v14 (phase-2 excluded) #29600

Conversation

ahinzmann commented Apr 30, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

perrotta commented Apr 30, 2020

cmsbuild commented Apr 30, 2020 • edited

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

slava77 commented May 2, 2020 via email

perrotta commented May 4, 2020 • edited

cmsbuild commented May 11, 2020

cmsbuild commented May 11, 2020

cmsbuild commented May 11, 2020

perrotta commented May 11, 2020

cmsbuild commented May 11, 2020 • edited

cmsbuild commented May 11, 2020

cmsbuild commented May 11, 2020

cmsbuild commented May 11, 2020

perrotta commented May 11, 2020

silviodonato commented May 14, 2020

santocch commented May 14, 2020

cmsbuild commented May 14, 2020

cmsbuild commented Apr 30, 2020 •

edited

perrotta commented May 4, 2020 •

edited

cmsbuild commented May 11, 2020 •

edited