CPPF emulator refactoring #29603
CPPF emulator refactoring #29603
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29603/14940
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29603/14968
|
|
A new Pull Request was created by @mileva for master. It involves the following packages: L1Trigger/L1TMuonCPPF @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
do you have any comments @rekovic ? |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
| // Endcap region only | ||
| if (region != 0) { | ||
| int int_theta = | ||
| (region == -1 ? 180. * 32. / 36.5 : 0.) + (float)region * global_theta * 32. / 36.5 - 8.5 * 32 / 36.5; |
There was a problem hiding this comment.
For the future, please define constants instead of using "magic numbers"
7.6 of https://cms-sw.github.io/cms_coding_rules.html
(I see these numbers were already existing in the file)
|
+1 |
PR description:
CPPF Emulator Refactoring
Currently, the CPPF emulator calls RecoLocalMuon.RPCRecHit.rpcRecHits_cfi in order to produce clusters.
The proposed branch aims to avoid callind the LocalReco code on a early stage like emulation
and from the other side to separate the two clusterizers - RPC Rechits and CPPF clusters
and thus to ensure a possibility for further independent work on both the packages.
PR validation:
tested with: runTheMatrix.py -l 10806.0
output: 10806.0_SingleMuPt1+SingleMuPt1_pythia8_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED Step5-PASSED - time date Thu Apr 30 16:10:55 2020-date Thu Apr 30 15:59:15 2020; exit: 0 0 0 0 0 0
1 1 1 1 1 1 tests passed, 0 0 0 0 0 0 failed
local test:
cmsRun L1Trigger/L1TMuonCPPF/test/step2_DIGI_L1_DIGI2RAW_HLT.py
Other tests and slides:
MC data produced with the current and new clusterizer comparison - matched in 100%
Experimetnal data comparison: CPPF emulator calling current (RPCRechit) clusterizer and the new CPPF clusterizer - matched in 100%
Slides:
https://indico.cern.ch/event/892112/contributions/3762940/attachments/1993832/3325539/cppfEmulatorWithDigi.pdf
https://indico.cern.ch/event/907310/contributions/3817691/attachments/2017161/3371674/cppfEmulatorWithDigi_8April.pdf
if this PR is a backport please specify the original PR and why you need to backport that PR:
@BrieucF @ftorresd