New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ME0 migration to DD4HEP #29609
ME0 migration to DD4HEP #29609
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29609/14950
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @silviodonato, @franzoni, @kpedro88, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 65e52a5 CMSSW: CMSSW_11_1_X_2020-04-30-2300 I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step1_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log20434.0 step1 runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step1_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log21234.0 step1 runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step1_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log23234.0 step1 runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step1_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1
|
+operations |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
@slomeo I'm sorry, you have to solve some conflict originated from #29632 in order to merge this PR. |
@silviodonato : the PR #29632 is not already signed and merged, why is it not possible to merge #29609 before #29632 ?
|
@silviodonato : ok, I have seen only now (i.e I have not performed a refresh) the PR #29632 is merged. I'll rebase my PR asap |
PR description:
ME0 migration to DD4HEP
Only code Geometry migration, no alignment, no sensitive detectors
PR validation:
They create some histos (see pdf attached in [*]) that compare dimensions/positions of different volumes (i.e Chambers and Strips) between Scenario2026D41 Sim Geom and Scenario2026D41 Geo Reco; the latter has been made by @watson-ij because there was a bug, related to ME0, within the code of FW Reco.
[*]
ME0_1.pdf
ME0_2.pdf
ME0_3.pdf
ME0_4.pdf
ME0_5.pdf
ME0_6.pdf
ME0_7.pdf
ME0_8.pdf
ME0_9.pdf
ME0_10.pdf
ME0_11.pdf
ME0_12.pdf