Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME0 migration to DD4HEP #29609

Closed
wants to merge 8 commits into from
Closed

ME0 migration to DD4HEP #29609

wants to merge 8 commits into from

Conversation

slomeo
Copy link
Contributor

@slomeo slomeo commented May 1, 2020

PR description:

ME0 migration to DD4HEP
Only code Geometry migration, no alignment, no sensitive detectors

PR validation:

  1. Made by ME0ValidateGeometryDD4hep_cfg.py and ME0ValidateGeomemtryOldDD_cfg.py.

They create some histos (see pdf attached in [*]) that compare dimensions/positions of different volumes (i.e Chambers and Strips) between Scenario2026D41 Sim Geom and Scenario2026D41 Geo Reco; the latter has been made by @watson-ij because there was a bug, related to ME0, within the code of FW Reco.

  1. runTheMatrix test, workflows # 18.0 ok

[*]
ME0_1.pdf
ME0_2.pdf
ME0_3.pdf
ME0_4.pdf
ME0_5.pdf
ME0_6.pdf
ME0_7.pdf
ME0_8.pdf
ME0_9.pdf
ME0_10.pdf
ME0_11.pdf
ME0_12.pdf

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29609/14950

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2020

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Configuration/Geometry
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/GEMGeometryBuilder
Geometry/MuonNumbering

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @silviodonato, @franzoni, @kpedro88, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @jshlee, @ptcox, @lecriste, @dildick, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented May 1, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5943/console Started: 2020/05/01 14:02

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2020

-1

Tested at: 65e52a5

CMSSW: CMSSW_11_1_X_2020-04-30-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af95ee/5943/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
20034.0 step1

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step1_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

20434.0 step1
runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step1_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log

21234.0 step1
runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step1_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log

23234.0 step1
runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step1_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2020

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

+1
Tested at: d101060
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af95ee/6148/summary.html
CMSSW: CMSSW_11_1_X_2020-05-06-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af95ee/6148/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 45
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697163
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented May 7, 2020

+1

@perrotta
Copy link
Contributor

perrotta commented May 8, 2020

+1

  • Geometry related pull request: changes for reco are just technical, and involve the replacement of "ME0GeometryBuilderFromDDD" with "ME0GeometryBuilder" in a test script in RecoLocalMuon/GEMRecHit/test/SingleMuPt100_cfi_GEM-SIM-DIGI_Extended2015MuonGEMDev.py
  • Jenkins tests pass

@silviodonato
Copy link
Contributor

+operations

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

silviodonato commented May 12, 2020

@slomeo I'm sorry, you have to solve some conflict originated from #29632 in order to merge this PR.
PS. please tag myself (@silviodonato) as soon as you have solved the conflicts

@slomeo
Copy link
Contributor Author

slomeo commented May 12, 2020

@silviodonato : the PR #29632 is not already signed and merged, why is it not possible to merge #29609 before #29632 ?

@slomeo I'm sorry, you have to solve some conflict originated from #29632 in order to merge this PR.
PS. please tag myself (@silviodonato) as soon as you have solved the conflicts

@slomeo
Copy link
Contributor Author

slomeo commented May 12, 2020

@silviodonato : ok, I have seen only now (i.e I have not performed a refresh) the PR #29632 is merged. I'll rebase my PR asap

@slomeo slomeo mentioned this pull request May 12, 2020
@slomeo
Copy link
Contributor Author

slomeo commented May 12, 2020

I have decided to re-start with a new PR within a new IB. The new PR is #29813 .
The PR #29609 will be closed asap.

@slomeo slomeo closed this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants