Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move EcalPedestalHistory in to plugins directory to avoid duplicate d… #29618

Merged
merged 1 commit into from May 5, 2020
Merged

move EcalPedestalHistory in to plugins directory to avoid duplicate d… #29618

merged 1 commit into from May 5, 2020

Conversation

smuzaffar
Copy link
Contributor

Backport of #27915
Move EcalPedestalHistory to plugin directory to avoid duplicate dictionary errors in IBs

https://cmssdt.cern.ch/SDT/cgi-bin/showDupDict.py//slc7_amd64_gcc700/www/fri/10.6-fri-11/CMSSW_10_6_X_2020-05-01-1100/testLogs/dupDict-edmPD.log

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_10_6_X.

It involves the following packages:

CondTools/Ecal

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5959/console Started: 2020/05/02 08:38

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

+1
Tested at: ffe72e4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13a891/5959/summary.html
CMSSW: CMSSW_10_6_X_2020-05-01-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13a891/5959/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211986
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@ggovi
Copy link
Contributor

ggovi commented May 5, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 482ff56 into cms-sw:CMSSW_10_6_X May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants