New BeamSpot Object and Records

[francescobrivio]

PR description:

This PR introduces one new BeamSpot object and three new BeamSpot records that will be used to pass the BeamSpot information to the HLT on a lumi-by-lumi basis.
Newly introduced objets:

• BeamSpotOnlineObjects inherits from the already existing BeamSpotObjects and contains few new members (last analyzed lumi, run and fill)
• BeamSpotOnlineHLTObjectsRcd and BeamSpotOnlineLegacyObjectsRcd are two new records based on the BeamSpotOnlineObjects that will hold the information from the two running BeamSpot DQM clients
• BeamSpotTransientObjectsRcd is a dependent record that depends on BeamSpotOnlineHLTObjectsRcd and BeamSpotOnlineLegacyObjectsRcd and holds the final beamspot that will be passed to HLT
• Few new plugins for writing and reading the new BeamSpot records are placed under CondTools/BeamSpot

Coming next

This PR will be followed by two other PRs:

1. To include the production of the new BeamSpot records in the DQM BeamSpot clients (under DQM/BeamMonitor and DQM/Integration)
2. ESProducer and all necessary code to pass the final BeamSpot value to the HLT

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29662/15062

• This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29662/15062/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29662/15062/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly
• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29662/15062/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29662/15062/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29662/15138

• This PR adds an extra 64KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

CondCore/BeamSpotPlugins
CondCore/Utilities
CondFormats/BeamSpotObjects
CondFormats/DataRecord
CondTools/BeamSpot

@christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

ERROR: empty variable. PR had errors - #29662.

[cmsbuild]

-1

Tested at: e2982ad

CMSSW: CMSSW_11_1_X_2020-05-18-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75a25e/6423/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

[cmsbuild]

Comparison job queued.

[francescobrivio]

From the error logs I see a 'ScheduleExecutionFailure', so I don't think this failure is related to my commits.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75a25e/6423/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 48
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694369
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6433/console Started: 2020/05/19 19:08

[cmsbuild]

+1
Tested at: e2982ad
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75a25e/6433/summary.html
CMSSW: CMSSW_11_1_X_2020-05-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75a25e/6433/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 48
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694369
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[silviodonato]

merge
FYI alca: @pohsun @tlampen @tocheng @christopheralanwest