Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up BuildFiles under PhysicsTools/ #29692

Merged
merged 2 commits into from May 8, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 5, 2020

Clean up BuildFile.xml filea with xmllint --format.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29692/15093

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6063/console Started: 2020/05/05 18:46

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

PhysicsTools/CandAlgos
PhysicsTools/CandUtils
PhysicsTools/CondLiteIO
PhysicsTools/FWLite
PhysicsTools/HepMCCandAlgos
PhysicsTools/Heppy
PhysicsTools/HeppyCore
PhysicsTools/IsolationAlgos
PhysicsTools/IsolationUtils
PhysicsTools/JetCharge
PhysicsTools/JetExamples
PhysicsTools/JetMCAlgos
PhysicsTools/JetMCUtils
PhysicsTools/KinFitter
PhysicsTools/MVAComputer
PhysicsTools/MXNet
PhysicsTools/NanoAOD
PhysicsTools/ONNXRuntime
PhysicsTools/ParallelAnalysis
PhysicsTools/PatAlgos
PhysicsTools/PatExamples
PhysicsTools/PatUtils
PhysicsTools/PythonAnalysis
PhysicsTools/RecoAlgos
PhysicsTools/RecoUtils
PhysicsTools/SelectorUtils
PhysicsTools/TagAndProbe
PhysicsTools/TensorFlow
PhysicsTools/UtilAlgos
PhysicsTools/Utilities

@perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @makortel, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @hqucms, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

Clean up BuildFile.xml filea with `xmllint --format`.
@fwyzard fwyzard force-pushed the branch_lintBuildFile_PhysicsTools branch from d616e59 to 9b5d5a6 Compare May 5, 2020 17:20
@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29692/15159

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6121/console Started: 2020/05/06 00:05

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6139/console Started: 2020/05/06 16:26

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Pull request #29692 was updated. @perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

+1
Tested at: b070891
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10fb44/6139/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10fb44/6139/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697207
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@perrotta
Copy link
Contributor

perrotta commented May 6, 2020

@peruzzim
Copy link
Contributor

peruzzim commented May 7, 2020

+xpog

@santocch
Copy link

santocch commented May 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 23a3453 into cms-sw:master May 8, 2020
@fwyzard fwyzard deleted the branch_lintBuildFile_PhysicsTools branch May 8, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants