Restructured code of againstElectronDeadECAL tauID (10_6_X) #29739

mbluj · 2020-05-05T14:31:07Z

PR description:

Restructured code of againstElectronDeadECAL discriminator to run on either AOD or miniAOD inputs (backport of #29627):

add a version of the discriminant to run on top of pat::Taus to be used with miniAOD data samples;
use eta and phi of impact position of the leading PFChargedHadron on ECal surface instead of eta and phi of tau at the vertex (taking bending of track in the magnetic field and the zVertex into account) - feature disabled by default for backwards compatibility;
restructure the code in the way that both AOD and miniAOD version of the discriminant call the same algorithm to avoid code duplication;
move code performing the extrapolation to the ECal surface from the againstElectronMVA algorithm to an auxiliary helper class which avoids code duplication;
add output of the againstElectronDeadECAL discriminant produced with AOD inputs (with the extrapolation to ECal surface) to miniAOD workflows for future reMiniAOD with run2_miniAOD_devel era (features for UL re-miniAOD in 10_6_X #27889)

Expected some differences:

none with default workflows,
new tauID embedded into slimmedTaus and slimmedTausBoosted in miniAOD with run2_miniAOD_devel era.

PR validation:

runTheMatrix.py -l limited -i all passed successfully except a few failed due to problem with inputs (DAS_ERROR).

if this PR is a backport please specify the original PR and why you need to backport that PR:

It is backport of #29627

…n either AOD or miniAOD inputs - use eta and phi of impact position of leadingPFChargedHadron on ECAL surface instead of eta and phi of tau at the vertex (taking bending of track in the magnetic field and the zVertex into - account; disabled by default for backwards compatiblity) - add discriminator againstElectronDeadECAL to pat::Taus

…atibility

…metics

…d patTausBoosted

cmsbuild · 2020-05-05T14:31:34Z

A new Pull Request was created by @mbluj for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoTauTag/RecoTau

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

Backported from Restructured code of againstElectronDeadECAL tauID #29627

perrotta · 2020-05-06T12:15:03Z

backport of #29627

slava77 · 2020-05-07T17:53:27Z

@cmsbuild please test

cmsbuild · 2020-05-07T17:53:52Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6164/console Started: 2020/05/07 19:54

cmsbuild · 2020-05-07T19:14:20Z

+1
Tested at: aea7414
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4315/6164/summary.html
CMSSW: CMSSW_10_6_X_2020-05-07-1100
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-05-07T19:14:22Z

Comparison job queued.

cmsbuild · 2020-05-07T20:38:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4315/6164/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3212324
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211989
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

santocch · 2020-05-10T20:43:46Z

+1

slava77 · 2020-05-25T12:37:14Z

@cmsbuild please test

cmsbuild · 2020-05-25T12:37:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6563/console Started: 2020/05/25 14:41

cmsbuild · 2020-05-25T14:02:48Z

+1
Tested at: a1006be
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4315/6563/summary.html
CMSSW: CMSSW_10_6_X_2020-05-25-1100
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-05-25T14:02:51Z

Comparison job queued.

cmsbuild · 2020-05-25T15:33:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4315/6563/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3212324
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211986
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77 · 2020-05-26T23:34:41Z

+1

for #29739 a1006be

this backport is consistent with the master version, apart for the expected changes in PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py to accommodate the no-change rule with run2_miniAOD_devel modifier
jenkins tests pass and comparisons with the baseline show no (relevant) differences

santocch · 2020-05-27T20:27:44Z

+1

cmsbuild · 2020-05-27T20:28:09Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-28T06:58:13Z

+1

slava77 · 2020-07-31T22:40:36Z

PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py

+    process.hpsPFTauDiscriminationByDeadECALElectronRejectionForMiniAOD = \
+        process.hpsPFTauDiscriminationByDeadECALElectronRejection.clone(
+            extrapolateToECalEntrance = True
+        )


After debugging the discrepancy for UL re-miniAOD in 106X and master, it seems to me that this new module name is not an optimal solution.

here in 10_6_X it's a bit semantic (the final result is as expected)

in the master branch we apparently have a wrong behavior: the 94X and UL reminiAODs are silently picking up hpsPFTauDiscriminationByDeadECALElectronRejection from the input file

I think that the more appropriate solution would be to

in 106X:

remove hpsPFTauDiscriminationByDeadECALElectronRejectionForMiniAOD in 106X

add run2_miniAOD_devel.toModify(hpsPFTauDiscriminationByDeadECALElectronRejection, extrapolateToECalEntrance = True) in RecoTauTag/Configuration/python/HPSPFTaus_cff.py

keep injection of the regular hpsPFTauDiscriminationByDeadECALElectronRejection in the makePatTausTask

in the master

inject hpsPFTauDiscriminationByDeadECALElectronRejection in the makePatTausTask for run2_miniAOD_UL and run2_miniAOD_94XFall17

Yes, I agree with this comment; this interference between modules included in different eras have been overlooked in this PR. Should be this issue for 106X resolved as part of this PR or as another one? (+ PR for master in both options).

Should be this issue for 106X resolved as part of this PR or as another one? (+ PR for master in both options).

the latter.
(nothing can practically be done to a PR that would affect the code after the PR is merged)

Right! Overlooked/forgotten that this one is merged - too many items to address after holidays :)

veelken and others added 5 commits April 27, 2020 17:58

Remove deadECal tauID from default patTau configuration for back comp…

ca64013

…atibility

Change argument of deadECal operator(), add verbosity, code style cos…

0ee0e65

…metics

Add against deadEcal tauID (with extrapolation to ECal) to patTaus an…

b631c40

…d patTausBoosted

code style cosmetics

aea7414

cmsbuild added this to the CMSSW_10_6_X milestone May 5, 2020

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 5, 2020

mbluj changed the title ~~Restructured code of againstElectronDeadECAL tauID~~ Restructured code of againstElectronDeadECAL tauID (10_6_X) May 5, 2020

This was referenced May 6, 2020

Add tauID against electrons in deadECAL regions cms-nanoAOD/cmssw#519

Closed

features for UL re-miniAOD in 10_6_X #27889

Closed

cmsbuild added the backport label May 6, 2020

cmsbuild added tests-started and removed tests-pending labels May 7, 2020

cmsbuild added tests-approved and removed tests-started labels May 7, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 7, 2020

cmsbuild added the backport-ok label May 25, 2020

cmsbuild added tests-started and removed tests-pending labels May 25, 2020

cmsbuild added tests-approved and removed tests-started labels May 25, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 25, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels May 26, 2020

slava77 mentioned this pull request May 27, 2020

Restructured code of againstElectronDeadECAL tauID (10_2_X) #29747

Merged

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels May 27, 2020

cmsbuild added orp-approved and removed orp-pending labels May 28, 2020

cmsbuild merged commit aa544ff into cms-sw:CMSSW_10_6_X May 28, 2020

mbluj deleted the CMSSW_10_6_X_tau-pog_deadECAL branch May 28, 2020 09:00

mbluj mentioned this pull request May 28, 2020

Add tauID against electrons in dead ECal regions (106X) cms-nanoAOD/cmssw#521

Closed

slava77 reviewed Jul 31, 2020

View reviewed changes

slava77 mentioned this pull request Jul 31, 2020

enable hpsPFTauDiscriminationByDeadECALElectronRejection in run2 reminiAODs #31015

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restructured code of againstElectronDeadECAL tauID (10_6_X) #29739

Restructured code of againstElectronDeadECAL tauID (10_6_X) #29739

mbluj commented May 5, 2020 •

edited

cmsbuild commented May 5, 2020 •

edited

perrotta commented May 6, 2020

slava77 commented May 7, 2020

cmsbuild commented May 7, 2020 •

edited

cmsbuild commented May 7, 2020

cmsbuild commented May 7, 2020

cmsbuild commented May 7, 2020

santocch commented May 10, 2020

slava77 commented May 25, 2020

cmsbuild commented May 25, 2020 •

edited

cmsbuild commented May 25, 2020

cmsbuild commented May 25, 2020

cmsbuild commented May 25, 2020

slava77 commented May 26, 2020

santocch commented May 27, 2020

cmsbuild commented May 27, 2020

silviodonato commented May 28, 2020

slava77 Jul 31, 2020

mbluj Aug 3, 2020

slava77 Aug 3, 2020

mbluj Aug 3, 2020

Restructured code of againstElectronDeadECAL tauID (10_6_X) #29739

Restructured code of againstElectronDeadECAL tauID (10_6_X) #29739

Conversation

mbluj commented May 5, 2020 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 5, 2020 • edited

perrotta commented May 6, 2020

slava77 commented May 7, 2020

cmsbuild commented May 7, 2020 • edited

cmsbuild commented May 7, 2020

cmsbuild commented May 7, 2020

cmsbuild commented May 7, 2020

santocch commented May 10, 2020

slava77 commented May 25, 2020

cmsbuild commented May 25, 2020 • edited

cmsbuild commented May 25, 2020

cmsbuild commented May 25, 2020

cmsbuild commented May 25, 2020

slava77 commented May 26, 2020

santocch commented May 27, 2020

cmsbuild commented May 27, 2020

silviodonato commented May 28, 2020

slava77 Jul 31, 2020

Choose a reason for hiding this comment

mbluj Aug 3, 2020

Choose a reason for hiding this comment

slava77 Aug 3, 2020

Choose a reason for hiding this comment

mbluj Aug 3, 2020

Choose a reason for hiding this comment

mbluj commented May 5, 2020 •

edited

cmsbuild commented May 5, 2020 •

edited

cmsbuild commented May 7, 2020 •

edited

cmsbuild commented May 25, 2020 •

edited