Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT master] Add direct deps after ROOT cleanup #29740

Merged
merged 1 commit into from May 15, 2020

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented May 5, 2020

PR description:

Adds direct dependencies for used types namely TObjString, TFile and std::set
See: cms-sw/cmsdist#5800 and https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370a62/5988/build-logs/
We had the types present included indirectly by other headers (I'd guess)
I didn't want to open 10 PRs with one line change, hence the multiple categories

PR validation:

Builds with ROOT_X IB (given we have the GL installed, I copied it by hand for the test, it built)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29740/15144

  • This PR adds an extra 108KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29740/15147

  • This PR adds an extra 108KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

Alignment/OfflineValidation
Calibration/HcalCalibAlgos
DQM/L1TMonitorClient
Fireworks/Core
IOPool/Output
RecoTauTag/RecoTau
SimG4Core/HelpfulWatchers
SimTransport/TotemRPProtonTransportParametrization

@perrotta, @smuzaffar, @andrius-k, @Dr15Jones, @alja, @makortel, @schneiml, @tlampen, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @slava77, @tocheng, @pohsun can you please review it and eventually sign? Thanks.
@adewit, @makortel, @riga, @wddgit, @alja, @tocheng, @tlampen, @mschrode, @mmusich, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5800
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6113/console Started: 2020/05/05 22:11

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6325/console Started: 2020/05/15 05:46

@cmsbuild
Copy link
Contributor

+1
Tested at: 41a9dfb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d45429/6325/summary.html
CMSSW: CMSSW_11_1_X_2020-05-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d45429/6325/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2702162
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2701842
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

+1

@smuzaffar
Copy link
Contributor

+core

@smuzaffar
Copy link
Contributor

@silviodonato , can we get this in? It is just a technical update to explicitly add the includes which are cleaned up in root master. This is blocking the integration of root master.

@perrotta
Copy link
Contributor

+1

  • Technical
  • Jenkins tests pass

@silviodonato
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants