-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip hybrid zero suppression: do less work if the APV is already zero-suppressed #29759
Merged
cmsbuild
merged 7 commits into
cms-sw:master
from
pieterdavid:stripHybridZeroSuppression_copyIfFEDZS_1110pre5
May 15, 2020
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
512f2cf
Add alternative suppressHybrid(module), doing less work for already z…
pieterdavid d5f3e2f
SiStripZeroSuppression: disable produceRawDigis for hybrid inputs
pieterdavid b3d2237
Simplify new suppressHybridData a bit
pieterdavid 10a0874
group all code in the faster suppressHybridData method, and make it u…
pieterdavid b65aa82
Same for regional unpacker
pieterdavid 3a967bd
Remove old methods, rename new to suppressHybridData
pieterdavid 4abf09d
LogWarning->LogInfo
pieterdavid File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth to throw here instead?
Given that this is a stream module, IIUC, we'll get nThread counts of these warnings in the log file.
If instead of exception this condition is OK and this message is only useful for experts, perhaps a LogInfo is better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK as long as the product isn't used (and if it is, there will be a ProductNotFound exception), so I made it a LogInfo indeed (in any case this option would only be used by experts).