Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVM10] Fixing compilation warnings for ALCA/DB #29776

Merged
merged 2 commits into from May 11, 2020
Merged

[LLVM10] Fixing compilation warnings for ALCA/DB #29776

merged 2 commits into from May 11, 2020

Conversation

smuzaffar
Copy link
Contributor

PR description:

LLVM 10 (in CLANG IBs) complains about object backing the pointer will be destroyed at the end of the full-expression. These changes are to avoid such warnings.

PR validation:

Local compilation for CLANG and normal IBs show no warnings.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29776/15233

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6180/console Started: 2020/05/08 14:47

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondFormats/PCLConfig
CondFormats/RPCObjects

@christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6184/console Started: 2020/05/08 15:43

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

+1
Tested at: 1fb8fcb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3bb0c/6184/summary.html
CMSSW: CMSSW_11_1_X_2020-05-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3bb0c/6184/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697206
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@pohsun
Copy link

pohsun commented May 10, 2020

+1

@silviodonato
Copy link
Contributor

merge
FYI @ggovi

@cmsbuild cmsbuild merged commit f039d3d into cms-sw:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants