Move muon SelectionType and Selector string to enum maps to muon namespace

[dntaylor]

PR description:

The goal here is to make available the list of Selectors or SelectionType enums in a given release available as strings. Specifically for analysis based recipes (like TagAndProbe) that want to store all supported Selectors but not have to manually update the code when new IDs are released.

For example:

      // add reco::Muon::Selector
      for (auto selToEnum : muon::selectorStringToEnumMap) {
        if (selToEnum.label == nullptr) continue;
        branches_["muon_"+std::string(selToEnum.label)].push_back(muon.passed(selToEnum.value));
      }

PR validation:

runTheMatrix (so I didn't break anything) and the above example in a ntuplizer works as expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29786/15244

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29786/15244/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29786/15244/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29786/15245

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @dntaylor (Devin Taylor) for master.

It involves the following packages:

DataFormats/MuonReco

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @cericeci, @rovere, @trocino, @amagitte, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@dntaylor
why is this marked as a Draft?
Is it not ready from your side?

[dntaylor]

No, I wanted to have the muon reco L3 look at it first. I didn't think it would trigger the review process if it was in draft. Next time I'll just pass around the comparison URL.

[slava77]

No, I wanted to have the muon reco L3 look at it first. I didn't think it would trigger the review process if it was in draft. Next time I'll just pass around the comparison URL.

OK.
Once a PR is submitted to the central cms-sw/cmssw it shows up in our/L2 review list.
Drafts or "RFC" are often made to request comments from developers or L2s at large for something that's not settled yet, but the PR description better be clear about the initial target audience.
For code that may just need checks/review by the internal POG community, perhaps having a group repo area is more practical.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29786/15278

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #29786 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6221/console Started: 2020/05/11 16:17

[cmsbuild]

+1
Tested at: 1c92d45
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de22f2/6221/summary.html
CMSSW: CMSSW_11_1_X_2020-05-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de22f2/6221/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697527
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697206
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #29786 1c92d45

• muon::selectionTypeStringToEnumMap and muon::selectorStringToEnumMap are now available via MuonSelectors.h, as described, for analysis needs
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1