Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UL remini updates: fix running PUPPI, add egamma scale and smearing #29826

Merged
merged 3 commits into from May 14, 2020
Merged

UL remini updates: fix running PUPPI, add egamma scale and smearing #29826

merged 3 commits into from May 14, 2020

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented May 13, 2020

tested on 136.88811

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 13, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29826/15349

  • This PR adds an extra 28KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

PhysicsTools/PatAlgos
RecoEgamma/EgammaPhotonProducers
RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jainshilpi, @hatakeyamak, @emilbols, @lgray, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @varuns23, @jdolen, @ferencek, @Sam-Harper, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @sobhatta, @lecriste, @afiqaize, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented May 13, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6275/console Started: 2020/05/13 17:02

@slava77 slava77 mentioned this pull request May 13, 2020
Closed
@slava77 slava77 mentioned this pull request May 13, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cms-bot#1302
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6277/console Started: 2020/05/13 17:10

@cmsbuild
Copy link
Contributor

+1
Tested at: 6e23152
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92569f/6277/summary.html
CMSSW: CMSSW_11_1_X_2020-05-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92569f/6277/summary.html

There are some workflows for which there are errors in the baseline:
136.88811 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697695
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697351
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 149 log files, 16 edm output root files, 34 DQM output files

@perrotta perrotta mentioned this pull request May 14, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #29832
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6298/console Started: 2020/05/14 12:40

@perrotta perrotta mentioned this pull request May 14, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #29837
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6299/console Started: 2020/05/14 14:11

@cmsbuild
Copy link
Contributor

+1
Tested at: 6e23152
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34b481/6298/summary.html
CMSSW: CMSSW_11_1_X_2020-05-13-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@slava77 slava77 mentioned this pull request May 14, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #29836
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6301/console Started: 2020/05/14 14:56

@slava77 slava77 mentioned this pull request May 14, 2020
Closed
41 tasks
@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #29604
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6303/console Started: 2020/05/14 15:53

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34b481/6298/summary.html

There are some workflows for which there are errors in the baseline:
136.88811 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697695
  • DQMHistoTests: Total failures: 37
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697339
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 149 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #29810
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6304/console Started: 2020/05/14 16:36

@silviodonato silviodonato mentioned this pull request May 14, 2020
Merged
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) #29784

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) #29830

@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #29825
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6309/console Started: 2020/05/14 17:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved code-checks-approved comparison-available fully-signed orp-approved reconstruction-approved requires-external tests-started
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

REMINIAOD workflows crash
5 participants
@slava77 @cmsbuild @silviodonato @santocch @slava77devel