MillePede: force user to specify cosmics-related settings #29838
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29838/15375
|
|
A new Pull Request was created by @adewit for master. It involves the following packages: Alignment/MillePedeAlignmentAlgorithm @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: c46bc3c CMSSW: CMSSW_11_1_X_2020-05-13-2300 I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/136.88811_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL/step2_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL.log |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
| tmpFile = re.sub(cdm_regex, | ||
| 'setupCosmicsDecoMode = True', | ||
| tmpFile) | ||
| if dataset["collection"] in ("ALCARECOTkAlCosmicsCTF0T", |
There was a problem hiding this comment.
@adewit as we have other track collections in the ALCARECO files, and we might add more in view of the work on CDCs I am wondering if this could become a check against a generic ALCARECOTkAlCosmics*.
There was a problem hiding this comment.
I think so - naively would expect I can turn the if statement around... will try a bit later
| if config["config"].has_option(section,"cosmicsDecoMode"): | ||
| self._datasets[name]["cosmicsDecoMode"] \ | ||
| = config["config"].getboolean(section,"cosmicsDecoMode") | ||
| if self._datasets[name]["collection"] in ("ALCARECOTkAlCosmicsCTF0T", |
…ALCARECOTkAlCosmics' in the name
cmsbuild
added
code-checks-pending
and removed
code-checks-approved
comparison-notrun
tests-rejected
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29838/15436
|
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-available
tests-approved
and removed
comparison-pending
tests-started
labels
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Changes the MillePede alignment setup scripts to force the user to specify certain options which were previously set by default (needed to ensure the settings don't accidentally get copied from elsewhere without the users' knowledge). Should not change any output of CMSSW unit tests.
cc @connorpa @vbotta
PR validation:
Verified (locally) the correct output for setting up the alignment is produced with the proposed changes
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport