New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed boost::array for std::array #29854
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29854/15406
|
A new Pull Request was created by @camolezi (Lucas Camolezi) for master. It involves the following packages: RecoMET/METAlgorithms @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@camolezi the HcalNoiseRBXArray class itself is still a boost:array |
Yes. I'm planning to update that too. Should I include that change in this PR? |
Why not?
Lucas Camolezi <notifications@github.com> ha scritto:
…> @camolezi the HcalNoiseRBXArray class itself is still a boost:array
> Do you plan to update also that?
Yes. I'm planning to update that too. Should I include that change
in this PR?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#29854 (comment)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29854/15420
|
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+1 |
PR description:
Updated boost::array to std::array. They should behave identically in this situation.
PR validation:
Passed on the basic runTheMatrix test.
if this PR is a backport please specify the original PR and why you need to backport that PR:
@vgvassilev @davidlange6