Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed boost::array for std::array #29854

Merged
merged 1 commit into from May 18, 2020
Merged

Conversation

camolezi
Copy link
Contributor

@camolezi camolezi commented May 15, 2020

PR description:

Updated boost::array to std::array. They should behave identically in this situation.

PR validation:

Passed on the basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29854/15406

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

RecoMET/METAlgorithms

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @ahinzmann, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented May 15, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6344/console Started: 2020/05/15 21:18

@cmsbuild
Copy link
Contributor

+1
Tested at: b631d46
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbccea/6344/summary.html
CMSSW: CMSSW_11_1_X_2020-05-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbccea/6344/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2702162
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2701827
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@perrotta
Copy link
Contributor

@camolezi the HcalNoiseRBXArray class itself is still a boost:array
Do you plan to update also that?

@camolezi
Copy link
Contributor Author

@camolezi the HcalNoiseRBXArray class itself is still a boost:array
Do you plan to update also that?

Yes. I'm planning to update that too. Should I include that change in this PR?

@perrotta
Copy link
Contributor

perrotta commented May 16, 2020 via email

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29854/15420

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #29854 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6356/console Started: 2020/05/17 08:26

@cmsbuild
Copy link
Contributor

+1
Tested at: 0e40b8f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbccea/6356/summary.html
CMSSW: CMSSW_11_1_X_2020-05-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbccea/6356/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694416
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@perrotta
Copy link
Contributor

+1

  • Technical
  • Jenkins tests pass

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit edbe589 into cms-sw:master May 18, 2020
@camolezi camolezi deleted the reduce-boost branch May 18, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants