disble illegal parameters when LHESource is used with steps

[srimanob]

PR description:

When cmsDriver.py is used with LHESource, it currently dumps with illegal parameters in process.source. This is an issue when LHE is used as a source for steps in private MC (not convert LHE to EDM first).

cmsDriver.py Configuration/GenProduction/python/ThirteenTeV/Hadronizer/Hadronizer_TuneCP5_13TeV_generic_LHE_pythia8_cff.py --filein file:1000GeV_SpinHalf_100.lhe --fileout file:RAW.root --mc --eventcontent PREMIXRAW --datatier GEN-SIM-RAW --conditions 106X_mc2017_realistic_v6 --step GEN,SIM,DIGI,DATAMIX,L1,DIGI2RAW,HLT:@relval2017 --beamspot Realistic25ns13TeVEarly2017Collision --procModifiers premix_stage2 --datamix PreMix --era Run2_2017 --nThreads 8 --geometry DB:Extended --pileup_input "dbs:/RelValPREMIXUP17_PU25/CMSSW_10_6_1-PU25ns_106X_mc2017_realistic_v6_UL17-v1/PREMIX" --python_filename GENToHLT_LHE_cfg.py -n -1 --no_exec

Cfg file:

process.source = cms.Source("LHESource",
dropDescendantsOfDroppedBranches = cms.untracked.bool(False),
fileNames = cms.untracked.vstring('file:1000GeV_SpinHalf_100.lhe'),
inputCommands = cms.untracked.vstring(
'keep *',

Error:

----- Begin Fatal Exception 15-May-2020 22:03:51 CEST-----------------------
An exception of category 'Configuration' occurred while
[0] Constructing the EventProcessor
[1] Validating configuration of input source of type LHESource
Exception Message:
Illegal parameters found in configuration. The parameters are named:
'dropDescendantsOfDroppedBranches'
'inputCommands'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

PR validation:

Using the same cmsDriver, now process.source comes with proper parameter:

process.source = cms.Source("LHESource",
fileNames = cms.untracked.vstring('file:1000GeV_SpinHalf_100.lhe')
)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Consider backporting to 10_6 release.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29855/15407

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): Deprecate convertToUnscheduled() customize function and --runUnscheduled argument of cmsDriver #29630

[cmsbuild]

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

Configuration/Applications

@cmsbuild, @silviodonato, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6364/console Started: 2020/05/18 09:58

[cmsbuild]

+1
Tested at: 05ceb2a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6999ae/6364/summary.html
CMSSW: CMSSW_11_1_X_2020-05-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6999ae/6364/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694415
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[silviodonato]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.