Optical function method for PPS proton transport #29857

mundim · 2020-05-15T21:50:51Z

PR description:

Implementation of the new method for proton transport to the PPS region based on Optical Functions from condDB and re-design of PPSProtonTransport and inclusion of ctpps_2021 Modifier (needed on this package).

PR validation:

All standard tests have ben performed with no issue, including code-checks and code-format

The runTheMatrix showed at first run the output:
34 32 29 24 16 4 1 1 1 tests passed, 0 1 2 0 0 0 0 0 0 failed

With the failing tests 136.793, 136.874 and 140.56 all of them after a few (tens) of events processed. Submitting only the failed ones again, with no change, all of them succeeded with output:

3 3 3 2 tests passed, 0 0 0 0 failed

Apparently it was

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

… to improve memory usage

cmsbuild · 2020-05-15T21:51:13Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-15T21:57:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29857/15409

This PR adds an extra 36KB to repository

cmsbuild · 2020-05-15T21:58:07Z

A new Pull Request was created by @mundim for master.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
SimTransport/PPSProtonTransport

@civanch, @silviodonato, @mdhildreth, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

civanch · 2020-05-16T17:45:42Z

please test

cmsbuild · 2020-05-16T17:46:06Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6353/console Started: 2020/05/16 19:48

cmsbuild · 2020-05-16T17:52:21Z

-1

Tested at: 9a66943

CMSSW: CMSSW_11_1_X_2020-05-16-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1e591/6353/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found compilation error when building:

>> Package SimPPS/PPSSimTrackProducer built
>> Entering Package SimPPS/PPSSimTrackProducer
Entering library rule at src/SimPPS/PPSSimTrackProducer/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-16-1100/src/SimPPS/PPSSimTrackProducer/plugins/PPSSimTrackProducer.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-16-1100/src/SimPPS/PPSSimTrackProducer/plugins/PPSSimTrackProducer.cc: In constructor 'PPSSimTrackProducer::PPSSimTrackProducer(const edm::ParameterSet&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-16-1100/src/SimPPS/PPSSimTrackProducer/plugins/PPSSimTrackProducer.cc:93:61: error: no matching function for call to 'TotemTransport::TotemTransport(const edm::ParameterSet&, bool&)'
     theTransporter = new TotemTransport(iConfig, m_verbosity);
                                                             ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-16-1100/src/SimPPS/PPSSimTrackProducer/plugins/PPSSimTrackProducer.cc:36:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-16-1100/src/SimTransport/PPSProtonTransport/interface/TotemTransport.h:25:3: note: candidate: 'TotemTransport::TotemTransport(const edm::ParameterSet&)'
   TotemTransport(const edm::ParameterSet& ps);

cmsbuild · 2020-05-16T17:52:23Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

… in SimTransport

mundim · 2020-05-16T21:25:48Z

Change in the constructor mistakenly not propagated to the calling class. Done. all testes have been done accordingly.

cmsbuild · 2020-05-16T21:31:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29857/15424

This PR adds an extra 40KB to repository

cmsbuild · 2020-05-16T21:31:50Z

Pull request #29857 was updated. @civanch, @silviodonato, @mdhildreth, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again.

civanch · 2020-05-17T12:00:19Z

please test

cmsbuild · 2020-05-17T12:00:43Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6359/console Started: 2020/05/17 15:00

cmsbuild · 2020-05-17T14:10:17Z

+1
Tested at: ce13f8c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1e591/6359/summary.html
CMSSW: CMSSW_11_1_X_2020-05-17-0000
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-17T14:10:19Z

Comparison job queued.

cmsbuild · 2020-05-17T15:39:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1e591/6359/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2694466
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2694416
DQMHistoTests: Total skipped: 49
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 150 log files, 16 edm output root files, 35 DQM output files

civanch · 2020-05-17T22:29:27Z

+1

silviodonato

I've just realized that yesterday I did not submit these comments :-( . Please implement them in the next PR.

silviodonato · 2020-05-18T08:22:36Z

SimPPS/PPSSimTrackProducer/plugins/PPSSimTrackProducer.cc

@@ -47,7 +49,7 @@ class PPSSimTrackProducer : public edm::stream::EDProducer<> {
  explicit PPSSimTrackProducer(const edm::ParameterSet&);
  ~PPSSimTrackProducer() override;

-  static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);
+  //static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);


please delete the commented lines of code.

silviodonato · 2020-05-18T08:22:51Z

SimPPS/PPSSimTrackProducer/plugins/PPSSimTrackProducer.cc

  m_InTag = iConfig.getParameter<edm::InputTag>("HepMCProductLabel");
  m_InTagToken = consumes<edm::HepMCProduct>(m_InTag);

  m_verbosity = iConfig.getParameter<bool>("Verbosity");
-  m_transportMethod = iConfig.getParameter<std::string>("TransportMethod");
+  //m_transportMethod = iConfig.getParameter<std::string>("TransportMethod");


silviodonato · 2020-05-18T08:22:59Z

SimPPS/PPSSimTrackProducer/plugins/PPSSimTrackProducer.cc

  }

  evt = new HepMC::GenEvent(*HepMCEvt->GetEvent());

-  theTransporter->clear();
+  //theTransporter->clear();


silviodonato · 2020-05-18T08:23:41Z

SimPPS/PPSSimTrackProducer/plugins/PPSSimTrackProducer.cc

 // ------------ method fills 'descriptions' with the allowed parameters for the module  ------------
+/*
 void PPSSimTrackProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
  //The following says we do not know what parameters are allowed so do no validation
  // Please change this to state exactly what you do use, even if it is no parameters
  edm::ParameterSetDescription desc;
  desc.setUnknown();
  descriptions.addDefault(desc);
 }
-
+*/


perhaps you can delete all this part

silviodonato · 2020-05-19T07:57:34Z

+1

cmsbuild · 2020-05-19T07:58:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

mundim added 3 commits May 14, 2020 07:19

New transport method for pps proton transport

5e14cca

adding 2021 Era for pps

1e681dc

Solving a bug in PPSTransportESSource_cff and deleting python objects…

9a66943

… to improve memory usage

cmsbuild added this to the CMSSW_11_1_X milestone May 15, 2020

cmsbuild added code-checks-pending comparison-pending operations-pending orp-pending pending-signatures simulation-pending tests-pending labels May 15, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 15, 2020

cmsbuild added tests-started and removed tests-pending labels May 16, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels May 16, 2020

Changing SimPPS/PPSSimTrasnProducer in view of the change implemented…

ce13f8c

… in SimTransport

cmsbuild removed code-checks-approved comparison-notrun tests-rejected labels May 16, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 16, 2020

cmsbuild added tests-started and removed tests-pending labels May 17, 2020

cmsbuild added tests-approved and removed tests-started labels May 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 17, 2020

cmsbuild added simulation-approved and removed simulation-pending labels May 17, 2020

silviodonato reviewed May 19, 2020

View reviewed changes

cmsbuild removed operations-pending orp-pending pending-signatures labels May 19, 2020

cmsbuild added fully-signed operations-approved orp-approved labels May 19, 2020

cmsbuild merged commit d5dcb31 into cms-sw:master May 19, 2020

mundim mentioned this pull request May 19, 2020

Remaining config files needed to implement PPS simulation into cmssw … #28190

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optical function method for PPS proton transport #29857

Optical function method for PPS proton transport #29857

mundim commented May 15, 2020

cmsbuild commented May 15, 2020

cmsbuild commented May 15, 2020

cmsbuild commented May 15, 2020

civanch commented May 16, 2020

cmsbuild commented May 16, 2020 •

edited

cmsbuild commented May 16, 2020

cmsbuild commented May 16, 2020

mundim commented May 16, 2020

cmsbuild commented May 16, 2020

cmsbuild commented May 16, 2020

civanch commented May 17, 2020

cmsbuild commented May 17, 2020 •

edited

cmsbuild commented May 17, 2020

cmsbuild commented May 17, 2020

cmsbuild commented May 17, 2020

civanch commented May 17, 2020

silviodonato left a comment

silviodonato May 18, 2020

silviodonato May 18, 2020

silviodonato May 18, 2020

silviodonato May 18, 2020

silviodonato commented May 19, 2020

cmsbuild commented May 19, 2020

Optical function method for PPS proton transport #29857

Optical function method for PPS proton transport #29857

Conversation

mundim commented May 15, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 15, 2020

cmsbuild commented May 15, 2020

cmsbuild commented May 15, 2020

civanch commented May 16, 2020

cmsbuild commented May 16, 2020 • edited

cmsbuild commented May 16, 2020

cmsbuild commented May 16, 2020

mundim commented May 16, 2020

cmsbuild commented May 16, 2020

cmsbuild commented May 16, 2020

civanch commented May 17, 2020

cmsbuild commented May 17, 2020 • edited

cmsbuild commented May 17, 2020

cmsbuild commented May 17, 2020

cmsbuild commented May 17, 2020

civanch commented May 17, 2020

silviodonato left a comment

Choose a reason for hiding this comment

silviodonato May 18, 2020

Choose a reason for hiding this comment

silviodonato May 18, 2020

Choose a reason for hiding this comment

silviodonato May 18, 2020

Choose a reason for hiding this comment

silviodonato May 18, 2020

Choose a reason for hiding this comment

silviodonato commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 16, 2020 •

edited

cmsbuild commented May 17, 2020 •

edited