Add more Run3 and Phase2 generator fragments #29859

akssikdar · 2020-05-16T11:31:16Z

PR description:

This PR append generator fragments for Run3 and Phase2 workflows.

PR includes
1. Added new generator fragments for BuMixing_BMuonFilter_forSTEAM_14TeV_TuneCP5 and Upsilon1SToMuMu_forSTEAM_14TeV_TuneCP5, intended to use for Run3 2021 workflows.
2. Added new generator fragments of TenTau_E_15_500_Eta3p1_pythia8 for Phase2 RelVal production.
3. Added corresponding entries for 1) and 2) in the RelVal submission macros (upgradeWorkflowComponents.py, relval_steps.py)

PR validation:

Tested locally with the related workflows and log file added:

runTheMatrix.py --what upgrade -l 23320.0,23321.0 -t 8 --command='-n 5' >& bumix_upsilon_run5evt.log

runTheMatrix.py --what upgrade -l 23322.0 -t 8 --command='--customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 -n 10' >& tentau_eta3p1_run10evt.log

bumix_upsilon_run5evt.log
tentau_eta3p1_run10evt.log

…and Upsilon1SToMuMu_forSTEAM_14TeV_TuneCP5

cmsbuild · 2020-05-16T11:31:42Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-16T11:37:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29859/15418

This PR adds an extra 76KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Deprecate convertToUnscheduled() customize function and --runUnscheduled argument of cmsDriver #29630
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase2-hgx240 Add 2 new scenarios for V12 of HGCAL #29827

cmsbuild · 2020-05-16T11:38:02Z

A new Pull Request was created by @akssikdar (Anup Kumar Sikdar) for master.

It involves the following packages:

Configuration/Generator
Configuration/PyReleaseValidation

@SiewYan, @pgunnell, @efeyazgan, @mkirsano, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

…V and Upsilon1SToMuMu_forSTEAM_14TeV

…nt for run3 wfs

cmsbuild · 2020-05-16T15:45:19Z

The code-checks are being triggered in jenkins.

Configuration/Generator/python/Upsilon1SToMuMu_forSTEAM_14TeV_TuneCP5_cfi.py

chayanit · 2020-05-16T15:48:29Z

Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

@@ -958,5 +958,8 @@ def __init__(self, howMuch, dataset):
    ('TauToMuMuMu_14TeV_TuneCP5_cfi', UpgradeFragment(Kby(18939,189393),'TauToMuMuMu_14TeV')), # effi = 5.280e-04
    ('BdToKstarEleEle_14TeV_TuneCP5_cfi', UpgradeFragment(Kby(206,2061),'BdToKstarEleEle_14TeV')), #effi = 4.850e-02 
    ('ZpTT_1500_14TeV_TuneCP5_cfi', UpgradeFragment(Kby(9,50),'ZpTT_1500_14')),
+    ('BuMixing_BMuonFilter_forSTEAM_14TeV_TuneCP5_cfi', UpgradeFragment(Kby(900,10000),'BuMixing_14')),
+    ('Upsilon1SToMuMu_forSTEAM_14TeV_TuneCP5_cfi', UpgradeFragment(Kby(9,50),'Upsilon1SToMuMu_14')),
+    ('TenTau_15_500_Eta3p1_pythia8_cfi', UpgradeFragment(Kby(9,100),'TenTau_E_15_500_Eta3p1')),


I was asking to remove _E from 'TenTau_E_15_500_Eta3p1' not from config file name.

Is it OK now?

cmsbuild · 2020-05-17T22:30:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6362/console Started: 2020/05/18 00:43

cmsbuild · 2020-05-17T23:56:19Z

+1
Tested at: d45fa5a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992a59/6362/summary.html
CMSSW: CMSSW_11_1_X_2020-05-17-0000
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-17T23:56:22Z

Comparison job queued.

cmsbuild · 2020-05-18T01:31:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992a59/6362/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2694466
DQMHistoTests: Total failures: 45
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2694372
DQMHistoTests: Total skipped: 49
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 150 log files, 16 edm output root files, 35 DQM output files

chayanit · 2020-05-18T10:09:03Z

+1
@silviodonato it would be nice to have this PR merged in pre8. Thank you

qliphy · 2020-05-18T11:29:19Z

+1

kpedro88 · 2020-05-18T18:51:41Z

+upgrade

cmsbuild · 2020-05-18T18:52:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-18T19:39:18Z

+1

akssikdar added 9 commits May 14, 2020 06:20

Create BuMixing_BMuonFilter_forSTEAM_14TeV_TuneCP5_cfi.py

fb5e394

Create Upsilon1SToMuMu_forSTEAM_14TeV_TuneCP5_cfi.py

4330080

Update eta(min/max) from 2.5 to 3.1

fc8db07

Adding GEN fragments for BuMixing_BMuonFilter_forSTEAM_14TeV_TuneCP5 …

5e07884

…and Upsilon1SToMuMu_forSTEAM_14TeV_TuneCP5

Create TenTau_E_15_500_Eta3p1_pythia8_cfi.py

1a8f4b8

Update eta(max/min) from 3.1 to 2.5

ca4d99b

Adding GenFragments for TenTau_E_15_500_Eta3p1_pythia8_cfi.py

27db47b

Adding GenFragments for BuMixing_14,Upsilon1SToMuMu_14

199bfd0

Adding GenFragments for TenTau_E_15_500_Eta3p1_pythia8_cfi.py

90f40c8

cmsbuild added this to the CMSSW_11_1_X milestone May 16, 2020

cmsbuild added code-checks-pending comparison-pending generators-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels May 16, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 16, 2020

akssikdar added 3 commits May 16, 2020 17:33

moving GenFragments for TenTau_E_15_500_Eta3p1_pythia8_cfi.py to bottom

db24621

Removing the modification made for BuMixing_BMuonFilter_forSTEAM_14Te…

027f5e0

…V and Upsilon1SToMuMu_forSTEAM_14TeV

renaming TenTau_E_15_500_Eta3p1 to TenTau_15_500_Eta3p1 to be consita…

7e0bd8a

…nt for run3 wfs

cmsbuild added code-checks-pending and removed code-checks-approved labels May 16, 2020

chayanit suggested changes May 16, 2020

View reviewed changes

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels May 17, 2020

cmsbuild added tests-started and removed tests-pending labels May 17, 2020

cmsbuild added tests-approved and removed tests-started labels May 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 18, 2020

cmsbuild added pdmv-approved and removed pdmv-pending labels May 18, 2020

cmsbuild added generators-approved and removed generators-pending labels May 18, 2020

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels May 18, 2020

cmsbuild added orp-approved and removed orp-pending labels May 18, 2020

cmsbuild merged commit 3c5534b into cms-sw:master May 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more Run3 and Phase2 generator fragments #29859

Add more Run3 and Phase2 generator fragments #29859

akssikdar commented May 16, 2020 •

edited

cmsbuild commented May 16, 2020

cmsbuild commented May 16, 2020

cmsbuild commented May 16, 2020

cmsbuild commented May 16, 2020

chayanit May 16, 2020

akssikdar May 16, 2020

cmsbuild commented May 17, 2020 •

edited

cmsbuild commented May 17, 2020

cmsbuild commented May 17, 2020

cmsbuild commented May 18, 2020

chayanit commented May 18, 2020

qliphy commented May 18, 2020

kpedro88 commented May 18, 2020

cmsbuild commented May 18, 2020

silviodonato commented May 18, 2020

Add more Run3 and Phase2 generator fragments #29859

Add more Run3 and Phase2 generator fragments #29859

Conversation

akssikdar commented May 16, 2020 • edited

PR description:

PR validation:

cmsbuild commented May 16, 2020

cmsbuild commented May 16, 2020

cmsbuild commented May 16, 2020

cmsbuild commented May 16, 2020

chayanit May 16, 2020

Choose a reason for hiding this comment

akssikdar May 16, 2020

Choose a reason for hiding this comment

cmsbuild commented May 17, 2020 • edited

cmsbuild commented May 17, 2020

cmsbuild commented May 17, 2020

cmsbuild commented May 18, 2020

chayanit commented May 18, 2020

qliphy commented May 18, 2020

kpedro88 commented May 18, 2020

cmsbuild commented May 18, 2020

silviodonato commented May 18, 2020

akssikdar commented May 16, 2020 •

edited

cmsbuild commented May 17, 2020 •

edited