Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip CUDA-related tests if no GPU is present #29902

Merged
merged 1 commit into from May 19, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 19, 2020

PR description:

Make unit tests that require a CUDA device skip the test and exit
succesfully if the CUDA runtime is not available, or no CUDA devices
are available.

Rename the cudautils namespace to cms::cuda or cms::cudatest, and
drop the CUDA prefix from the symbols defined there.

Make unit tests that require a CUDA device skip the test and exit
succesfully if the CUDA runtime is not available, or no CUDA devices
are available.

Rename the cudautils namespace to cms::cuda or cms::cudatest, and
drop the CUDA prefix from the symbols defined there.

Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>
@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 19, 2020
@fwyzard
Copy link
Contributor Author

fwyzard commented May 19, 2020

Update the HCAL tests from the Patatrack branch.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 19, 2020

@cmsbuild, please test

@fwyzard
Copy link
Contributor Author

fwyzard commented May 19, 2020

assign heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented May 19, 2020

enable gpu

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29902/15487

@cmsbuild
Copy link
Contributor

New categories assigned: heterogeneous

@makortel,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented May 19, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6413/console Started: 2020/05/19 10:30

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

DataFormats/HcalDetId
DataFormats/HcalDigi
DataFormats/HcalRecHit

@perrotta, @civanch, @makortel, @fwyzard, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @mariadalfonso, @abdoulline, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented May 19, 2020

+1

@cmsbuild
Copy link
Contributor

+1
Tested at: 033c3ba
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d47228/6413/summary.html
CMSSW: CMSSW_11_1_X_2020-05-18-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d47228/6413/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694369
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@perrotta
Copy link
Contributor

+1

  • Technical, it applies to cuda tests
  • Jenkinst tests pass

@civanch
Copy link
Contributor

civanch commented May 19, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6357a3d into cms-sw:master May 19, 2020
@fwyzard fwyzard deleted the patatrack_update_HCAL_tests branch May 19, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants