Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CUDAUtilities from the Patatrack development #29908

Merged
merged 2 commits into from May 20, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 19, 2020

PR description:

Introduce an STL-compatible allocator for CUDA host memory.

Remove dependency on NVIDIA cub.

Replace the use of the prefix scan from cub with a home-brewed implementation, using dynamic instead of static shared memory.

Annotate all CMS-specific changes to CachingDeviceAllocator.

No changes to physics or timing performance.

PR validation:

See cms-patatrack#447 and cms-patatrack#449.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 19, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29908/15501

@cmsbuild
Copy link
Contributor

cmsbuild commented May 19, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6425/console Started: 2020/05/19 16:13

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HeterogeneousCore/CUDAUtilities

@makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented May 19, 2020

enable gpu

@cmsbuild
Copy link
Contributor

+1
Tested at: e53e7bb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64dd3f/6425/summary.html
CMSSW: CMSSW_11_1_X_2020-05-18-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64dd3f/6425/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694369
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@makortel
Copy link
Contributor

test parameters

  • enable_tests = gpu

@makortel
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

Pull request #29908 was updated. @makortel, @cmsbuild, @fwyzard can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 20, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 20, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 31c0620 into cms-sw:master May 20, 2020
@fwyzard fwyzard deleted the patatrack_update_CUDAUtilities branch May 20, 2020 08:19
@cmsbuild
Copy link
Contributor

+1
Tested at: 2b5bfa7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64dd3f/6452/summary.html
CMSSW: CMSSW_11_1_X_2020-05-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

+1
Tested at: 2b5bfa7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64dd3f/6451/summary.html
CMSSW: CMSSW_11_1_X_2020-05-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64dd3f/6451/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 49
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694368
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@makortel
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants