Run3-ft22 Add 3 scripts to test 3 steps with geometry done through dd4hep #29923
Conversation
|
The code-checks are being triggered in jenkins. |
|
@cmsbuild Please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29923/15535
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: SimG4Core/Configuration @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| # --------------------------------start of new part---------------------------- | ||
| #Other statements | ||
|
|
||
| process.RandomNumberGeneratorService = cms.Service("RandomNumberGeneratorService", |
There was a problem hiding this comment.
@bsunanda , our default random number generator MixMaxRng and not HepJamesRandom, also initial integer better to be different for different producers. Make all = 69 may be acceptable but better having it different.
There was a problem hiding this comment.
I am removing that part. I took the script from Sergio and made minimal change to make it work - I am removing that.
|
@bsunanda is this supposed to be a runTheMatrix-like standard workflow? I had started to prepare for that in https://github.com/cms-sw/cmssw/blob/master/Geometry/CMSCommonData/test/dd4hep/runDD4hepTestWF.sh where only the step1 was functional at that time. What is different in these configurations compared to what you might get there by extending up to step3? This of course is just a test in view of a full integration in PyRelVal, but in practice it goes along the spirit of this PR, just using the standard tools instead of an explicit coding of each step. |
|
@fabiocos , just a comment: I need to test, for the Muon System, the DDD Geometry vs DD4hep Geometry (scenario 2021) by using MC Samples. I wrote 4 configuration files (from step1 to step4) in order to do it, by using Z->MuMu fragment at 14 TeV (in CMSSW_11_1_0_pre7). Step 4 is necessary in order to check quickly the differences among histos. When I added Configuration.Geometry.GeometryDD4hepExtended2021_cff or Configuration.Geometry.GeometryDD4hepExtended2021Reco_cff, suggested by @cvuosalo, in my configuration files I got some problems for step3, so I wrote to @bsunanda @ianna @cvuosalo @civanch to get help. |
|
@fabiocos @slomeo @civanch As Sergio mentioned he initiated this which triggered me to define a new ERA as in PR #29909. But the steps did not work and that was because issues in some of the detectors which are not usually looked after by me. So I thought it is better to have the scripts available to all so that the DPG contacts can at their corner can solve the respective problems. I would like to discuss this in tomorrow's meeting |
|
@cmsbuild Please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29923/15565
|
|
The tests are being triggered in jenkins. |
|
Pull request #29923 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
urgent |
cmsbuild
added
fully-signed
simulation-approved
urgent
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Add scripts to test the 3 steps for SIM-DIGI-RECO with Run3 geometry defined using dd4hep
PR validation:
The 3 scripts can work only after integrating PR #29909
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special