New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing online behaviour of DQMFileSaverPB #29924
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29924/15537
|
A new Pull Request was created by @Sam-Harper (Sam Harper) for master. It involves the following packages: DQMServices/FileIO @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a bug fix to the recent DQM revamp which solely effects the HLT when run by the DAQ. For hltd to properly collect and merge the dqm histogram stream produced by the HLT, it needs a init file to be written. Otherwise the stream is ignored and at best the histograms are lost.
This PR adds that code. It should have no effect on any offline test, this only effects P5 running.
PR validation:
The hilton tests successfully produced the DQM Histogram stream.