Run3-gem38 Correct ME0GeometryBuilder to take care of DDD and DD4HEP

[bsunanda]

PR description:

Correct ME0GeometryBuilder to take care of DDD and DD4HEP

PR validation:

Usethe runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[bsunanda]

@slomeo @watson-ij Please check that I have made changes for ME0 as well (to be kept for backward compatibility)

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29943/15579

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/GEMGeometryBuilder/src/ME0GeometryBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29943/15579/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29943/15579/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29943/15580

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/GEMGeometryBuilder/src/ME0GeometryBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/GEMGeometryBuilder
Geometry/MuonNumbering

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@jshlee, @ptcox, @dildick, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6489/console Started: 2020/05/21 21:17

[cmsbuild]

+1
Tested at: 9c3ab06
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7be55/6489/summary.html
CMSSW: CMSSW_11_1_X_2020-05-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7be55/6489/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 50
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694367
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7be55/6565/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780726
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[kpedro88]

+upgrade

[slomeo]

@bsunanda : is it possible to set "urgent" this PR?

[bsunanda]

@slomeo @civanch @cvuosalo I cannot set it as urgent. This can be done by Vladimir or Carl

[cvuosalo]

urgent

[cvuosalo]

+1

[cvuosalo]

@bsunanda This PR should be backported in 11_1, I think.

[bsunanda]

If one likes to use dd4hep in 11_1, this should be back ported. Also I am looking into a few other issues. A complete workout needs help from Yana

[cvuosalo]

@bsunanda I received the following error in CMSSW_11_1_X_2020-05-27-1100 using the old DD. I am hoping it would be fixed with this PR.

[2] Calling method for module CSCGeometryAnalyzer/'producer'
[3] Using EventSetup component CSCGeometryESModule/'' to make data CSCGeometry/'' in record MuonGeometryRecord
Exception Message:
No data of type "MuonGeometryConstants" with label "" in record "IdealGeometryRecord"
Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

[bsunanda]

@cvuosalo Please let me know the cfg file which cause this. I want this to be merged first and need to update several cff/cfg files. With this PR merged Sergio, Ian can proceed to look into further changes

[bsunanda]

@silviodonato Could you try to merge this PR - because other related changes from all muon sub detectors can start only after this is merged

[silviodonato]

merge
cc: alca: @pohsun @tlampen @tocheng @christopheralanwest

[cvuosalo]

@bsunanda The config Geometry/CSCGeometry/test/testCSCGeometry_cfg.py fails in CMSSW_11_1_X_2020-05-27-1100 with the error I listed. I didn't test whether this PR fixes the problem.