SiPixelClusterProducer: apply gain calibration scheme update at HLT as well #29951

mmusich · 2020-05-22T12:13:07Z

PR description:

Unfortunately the Pixel gain calibration scheme update introduced at #29333 missed the HLT configuration.
This PR provides the appropriate customization function to deal with the update of conditions also for the HLT.

PR validation:

Dumped the step3 configuration of https://cmsweb.cern.ch/couchdb/reqmgr_config_cache/95d680704ae17507a77b0e3350c8c1d5/configFile with and without this branch and obtained as expected:

$ colordiff dump.py dump2.py 
65455,65458c65455,65458
<     VCaltoElectronGain = cms.int32(47),
<     VCaltoElectronGain_L1 = cms.int32(50),
<     VCaltoElectronOffset = cms.int32(-60),
<     VCaltoElectronOffset_L1 = cms.int32(-670),
---
>     VCaltoElectronGain = cms.int32(1),
>     VCaltoElectronGain_L1 = cms.int32(1),
>     VCaltoElectronOffset = cms.int32(0),
>     VCaltoElectronOffset_L1 = cms.int32(0),
65484,65487c65484,65487
<     VCaltoElectronGain = cms.int32(47),
<     VCaltoElectronGain_L1 = cms.int32(50),
<     VCaltoElectronOffset = cms.int32(-60),
<     VCaltoElectronOffset_L1 = cms.int32(-670),
---
>     VCaltoElectronGain = cms.int32(1),
>     VCaltoElectronGain_L1 = cms.int32(1),
>     VCaltoElectronOffset = cms.int32(0),
>     VCaltoElectronOffset_L1 = cms.int32(0),
65513,65516c65513,65516
<     VCaltoElectronGain = cms.int32(47),
<     VCaltoElectronGain_L1 = cms.int32(50),
<     VCaltoElectronOffset = cms.int32(-60),
<     VCaltoElectronOffset_L1 = cms.int32(-670),
---
>     VCaltoElectronGain = cms.int32(1),
>     VCaltoElectronGain_L1 = cms.int32(1),
>     VCaltoElectronOffset = cms.int32(0),
>     VCaltoElectronOffset_L1 = cms.int32(0),
65542,65545c65542,65545
<     VCaltoElectronGain = cms.int32(47),
<     VCaltoElectronGain_L1 = cms.int32(50),
<     VCaltoElectronOffset = cms.int32(-60),
<     VCaltoElectronOffset_L1 = cms.int32(-670),
---
>     VCaltoElectronGain = cms.int32(1),
>     VCaltoElectronGain_L1 = cms.int32(1),
>     VCaltoElectronOffset = cms.int32(0),
>     VCaltoElectronOffset_L1 = cms.int32(0),

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport.

cc: @tsusa @dkotlins @tvami

mmusich · 2020-05-22T12:13:17Z

type bug-fix

mmusich · 2020-05-22T12:13:25Z

urgent

cmsbuild · 2020-05-22T12:13:34Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-22T12:19:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29951/15600

This PR adds an extra 12KB to repository

cmsbuild · 2020-05-22T12:19:59Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

HLTrigger/Configuration

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

mmusich · 2020-05-22T12:26:56Z

@cmsbuild, please test

cmsbuild · 2020-05-22T12:27:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6512/console Started: 2020/05/22 14:48

cmsbuild · 2020-05-22T13:57:17Z

+1
Tested at: e4cefbe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da6fcf/6512/summary.html
CMSSW: CMSSW_11_1_X_2020-05-21-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-22T13:57:20Z

Comparison job queued.

cmsbuild · 2020-05-22T15:27:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da6fcf/6512/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2694466
DQMHistoTests: Total failures: 13188
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2681229
DQMHistoTests: Total skipped: 49
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 150 log files, 16 edm output root files, 35 DQM output files

HLTrigger/Configuration/python/customizeHLTforCMSSW.py

cmsbuild · 2020-05-22T20:11:21Z

-1

Tested at: 1afecc5

CMSSW: CMSSW_11_1_X_2020-05-22-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da6fcf/6524/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
250202.181 step2

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

cmsbuild · 2020-05-22T20:11:23Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

mmusich · 2020-05-23T07:53:28Z

@cmsbuild, please test

The error message at link looks spurious.

cmsbuild · 2020-05-23T07:53:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6536/console Started: 2020/05/23 11:49

cmsbuild · 2020-05-23T11:00:14Z

+1
Tested at: 1afecc5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da6fcf/6536/summary.html
CMSSW: CMSSW_11_2_X_2020-05-22-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-23T11:00:16Z

Comparison job queued.

cmsbuild · 2020-05-23T14:44:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da6fcf/6536/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2780792
DQMHistoTests: Total failures: 13163
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2767579
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

Martin-Grunewald · 2020-05-25T06:11:35Z

+1

cmsbuild · 2020-05-25T06:12:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-25T07:24:46Z

+1

cmsbuild added this to the CMSSW_11_1_X milestone May 22, 2020

cmsbuild added bug-fix code-checks-pending comparison-pending hlt-pending orp-pending pending-signatures tests-pending urgent labels May 22, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 22, 2020

cmsbuild added tests-started and removed tests-pending labels May 22, 2020

cmsbuild added tests-approved and removed tests-started labels May 22, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 22, 2020

Martin-Grunewald reviewed May 22, 2020

View reviewed changes

HLTrigger/Configuration/python/customizeHLTforCMSSW.py Outdated Show resolved Hide resolved

applied gain calibration scheme update at HLT as well

1afecc5

mmusich force-pushed the fixPixelGainCalibrationAtHLT_29333 branch from e4cefbe to 1afecc5 Compare May 22, 2020 17:53

cmsbuild added tests-started and removed tests-pending labels May 22, 2020

mmusich mentioned this pull request May 22, 2020

[11.1.X] Applied gain calibration scheme update at HLT as well #29959

Merged

cmsbuild added tests-pending tests-started and removed tests-started tests-pending labels May 23, 2020

cmsbuild added tests-approved and removed tests-started labels May 23, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 23, 2020

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels May 25, 2020

cmsbuild added orp-approved and removed orp-pending labels May 25, 2020

cmsbuild merged commit a701bf2 into cms-sw:master May 25, 2020

mmusich deleted the fixPixelGainCalibrationAtHLT_29333 branch May 25, 2020 15:41

Martin-Grunewald mentioned this pull request May 26, 2020

HLT customisation update (112X) #29984

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SiPixelClusterProducer: apply gain calibration scheme update at HLT as well #29951

SiPixelClusterProducer: apply gain calibration scheme update at HLT as well #29951

mmusich commented May 22, 2020 •

edited

mmusich commented May 22, 2020

mmusich commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

mmusich commented May 22, 2020

cmsbuild commented May 22, 2020 •

edited

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

mmusich commented May 23, 2020

cmsbuild commented May 23, 2020 •

edited

cmsbuild commented May 23, 2020

cmsbuild commented May 23, 2020

cmsbuild commented May 23, 2020

Martin-Grunewald commented May 25, 2020

cmsbuild commented May 25, 2020

silviodonato commented May 25, 2020

SiPixelClusterProducer: apply gain calibration scheme update at HLT as well #29951

SiPixelClusterProducer: apply gain calibration scheme update at HLT as well #29951

Conversation

mmusich commented May 22, 2020 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

mmusich commented May 22, 2020

mmusich commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

mmusich commented May 22, 2020

cmsbuild commented May 22, 2020 • edited

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

mmusich commented May 23, 2020

cmsbuild commented May 23, 2020 • edited

cmsbuild commented May 23, 2020

cmsbuild commented May 23, 2020

cmsbuild commented May 23, 2020

Martin-Grunewald commented May 25, 2020

cmsbuild commented May 25, 2020

silviodonato commented May 25, 2020

mmusich commented May 22, 2020 •

edited

cmsbuild commented May 22, 2020 •

edited

cmsbuild commented May 23, 2020 •

edited