Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop type specs in RecoLocalCalo/{CaloTowersCreator,Configuration,EcalRecProducers} #29979

Merged
merged 5 commits into from May 28, 2020

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented May 25, 2020

Instead of modifying parameters with full type specs, which can be interpreted as an insertion of a new parameter,
it is a safer way to protect from parameter name mistakes and will also help in possible parameter migrations.

Additionally, in a few places this also moves parameter modifications in the clone method calls to the argument list instead of a separate line.

This PR is an example for the planned migration/update task.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29979/15649

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/Configuration
RecoLocalCalo/EcalRecProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rchatter, @apsallid, @rovere, @lecriste, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented May 25, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6573/console Started: 2020/05/25 18:22

@cmsbuild
Copy link
Contributor

+1
Tested at: e9b40ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-731b2b/6573/summary.html
CMSSW: CMSSW_11_2_X_2020-05-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-731b2b/6573/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 49
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780693
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@slava77
Copy link
Contributor Author

slava77 commented May 27, 2020

+1

for #29979 e9b40ab

  • jenkins tests confirmed no (relevant) differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants