Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-thread support for MadGraph LO process (106X) #30030

Merged
merged 1 commit into from May 30, 2020

Conversation

colizz
Copy link
Contributor

@colizz colizz commented May 28, 2020

PR description:

Implementing multi-thread support for MadGraph LO process.
The script run_generic_tarball_cvmfs_madgraphLO_multithread.sh script is designed as a replacement of run_generic_tarball_cvmfs.sh to enable the internal multithreading method of MadGraph. Another file is a patch that works together with this script.
More details can be found in the slides.

PR validation:

This PR does not touch the CMSSW framework.
Various gridpacks have been tested with this script for validation.

This PR is a backport from #30029

The implemented script is irrelevant to the CMSSW version, so it can always work.

(A quick test)

cmsrel CMSSW_10_6_X_2020-05-25-2300
cd CMSSW_10_6_X_2020-05-25-2300/src/
cmsenv
git cms-addpkg GeneratorInterface/LHEInterface
git cms-merge-topic colizz:dev-106X-madgraph-multithread

curl -s --insecure https://cms-pdmv.cern.ch/mcm/public/restapi/requests/get_fragment/SMP-RunIISummer19UL17wmLHEGEN-00001 --retry 2 --create-dirs -o Configuration/GenProduction/python/SMP-RunIISummer19UL17wmLHEGEN-00001-fragment.py
scram b -j 8
cd ../..
cmsDriver.py Configuration/GenProduction/python/SMP-RunIISummer19UL17wmLHEGEN-00001-fragment.py --fileout file:SMP-RunIISummer19UL17wmLHEGEN-00001.root --mc --eventcontent RAWSIM,LHE --datatier GEN,LHE --conditions 106X_mc2017_realistic_v6 --beamspot Realistic25ns13TeVEarly2017Collision --step LHE,GEN --geometry DB:Extended --era Run2_2017 --python_filename SMP-RunIISummer19UL17wmLHEGEN-00001_1_cfg.py --no_exec --customise Configuration/DataProcessing/Utils.addMonitoring --customise_commands process.source.numberEventsInLuminosityBlock="cms.untracked.uint32(2222)" -n 1200 --nThreads 4
sed -i "s/run_generic_tarball_cvmfs/run_generic_tarball_cvmfs_madgraphLO_multithread/g" SMP-RunIISummer19UL17wmLHEGEN-00001_1_cfg.py
cmsRun -e -j SMP-RunIISummer19UL17wmLHEGEN-00001_rt.xml SMP-RunIISummer19UL17wmLHEGEN-00001_1_cfg.py

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @colizz (Congqiao Li) for CMSSW_10_6_X.

It involves the following packages:

GeneratorInterface/LHEInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@colizz
Copy link
Contributor Author

colizz commented May 28, 2020

@cmsbuild please test

@qliphy
Copy link
Contributor

qliphy commented May 29, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6676/console Started: 2020/05/29 04:17

@cmsbuild
Copy link
Contributor

+1
Tested at: 2f07ea9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b07ef3/6676/summary.html
CMSSW: CMSSW_10_6_X_2020-05-28-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b07ef3/6676/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211957
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@qliphy
Copy link
Contributor

qliphy commented May 29, 2020

Adding @Dr15Jones

@colizz can you give a recipe to test this development with a MadGraph request from RunIISummer19UL17wmLHEGEN?

@colizz
Copy link
Contributor Author

colizz commented May 29, 2020

Thanks @qliphy. I now added the recipe in the beginning.

@Dr15Jones
Copy link
Contributor

I don't really have any comments as this implementation has no affect on the framework.

@qliphy
Copy link
Contributor

qliphy commented May 29, 2020

Thanks. I have tested the recipe locally at lxplus and it works.

@colizz Will you also backport #28913 ?

@qliphy
Copy link
Contributor

qliphy commented May 29, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@colizz
Copy link
Contributor Author

colizz commented May 30, 2020

@colizz Will you also backport #28913 ?

Yes, thanks @qliphy. I am actually planning to submit another PR, please see #30053 .

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5976711 into cms-sw:CMSSW_10_6_X May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants