Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop DtCalib AlCaReco Stream #30041

Merged
merged 4 commits into from Jun 4, 2020
Merged

Conversation

jfernan2
Copy link
Contributor

PR description:

This PR removes the DtCalib AlCaReco stream after agreement with the DT DPG.
It solves the issue raised on several comments from #29630 due to the transition to Tasks

PR validation:

runTheMatrix.py -l 25.0,1000.0,4.22,1001.0 -i all --ibeos -j 9 -t 9

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport foreseen

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@jfernan2
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30041/15745

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6684/console Started: 2020/05/29 15:01

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation
Configuration/StandardSequences

@pgunnell, @chayanit, @wajidalikhan, @christopheralanwest, @tocheng, @cmsbuild, @silviodonato, @franzoni, @kpedro88, @tlampen, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @tocheng, @lecriste, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 24f4c22
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-052703/6684/summary.html
CMSSW: CMSSW_11_2_X_2020-05-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-052703/6684/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2777394
  • DQMHistoTests: Total failures: 50
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2777294
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -5647.699 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -2263.521 KiB AlCaReco/DtCalibSynch
  • DQMHistoSizes: changed ( 1000.0 ): -1147.512 KiB AlCaReco/DTCalibration
  • DQMHistoSizes: changed ( 1000.0 ): -0.016 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1000.0 ): -0.016 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 4.22 ): -2236.367 KiB AlCaReco/DtCalibSynch
  • DQMHistoSizes: changed ( 4.22 ): -0.269 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 4.22 ): -0.107 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 4.22 ): 0.064 KiB total_warnings
  • DQMHistoSizes: changed ( 4.22 ): 0.044 KiB total_warnings.XrangeWithin:Warning
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@pohsun
Copy link

pohsun commented May 30, 2020

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 2, 2020

+upgrade

@silviodonato
Copy link
Contributor

+operations

@silviodonato
Copy link
Contributor

Do you have any objections @chayanit @pgunnell @wajidalikhan ?

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 8f69af3 into cms-sw:master Jun 4, 2020
@chayanit
Copy link

chayanit commented Jun 5, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants