Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mcdb and libhepml dependencies #30042

Merged
merged 3 commits into from Jun 2, 2020
Merged

Remove mcdb and libhepml dependencies #30042

merged 3 commits into from Jun 2, 2020

Conversation

smuzaffar
Copy link
Contributor

As proposed here #14728 , we think there is nothing in cmssw which is using mcdb libhepml.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#5886

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30042/15746

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5886
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6685/console Started: 2020/05/29 15:04

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

GeneratorInterface/LHEInterface
GeneratorInterface/MCatNLOInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 16ba386
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1b92e/6685/summary.html
CMSSW: CMSSW_11_2_X_2020-05-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1b92e/6685/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 88
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780654
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Jun 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fb31b0a into cms-sw:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants