Update accessor in CLCT and LCT data formats #30128

dildick · 2020-06-05T16:46:39Z

PR description:

Update the getFractionalStrip function LCT data format, and add a similar version in the CLCT data format.

EDIT:

Fix bug in the CSCCLCTDigi::operator== function. Change trivial statement getBend() == getBend() to getBend() == rhs.getBend()
CSCCLCTData was renamed to CSCComparatorData, since CLCTs are contained in the TMB data.
The unit test for CLCTs with 2007 firmware was fixed, and a unit test for 2013 firmware was added.
Several very old configurations (predating CMSSW _cfg.py style) have been deleted.

PR validation:

Tested with WF 27434.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cmsbuild · 2020-06-05T16:47:02Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-05T16:51:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30128/15906

This PR adds an extra 20KB to repository

cmsbuild · 2020-06-05T16:51:49Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@ptcox, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

civanch · 2020-06-06T13:26:29Z

please test

cmsbuild · 2020-06-06T13:26:55Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6854/console Started: 2020/06/06 15:28

cmsbuild · 2020-06-06T14:53:23Z

+1
Tested at: 21f700e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b516db/6854/summary.html
CMSSW: CMSSW_11_2_X_2020-06-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-06T14:53:26Z

Comparison job queued.

cmsbuild · 2020-06-06T16:59:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b516db/6854/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2780497
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2780446
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

cmsbuild · 2020-06-07T04:40:54Z

The code-checks are being triggered in jenkins.

perrotta · 2020-06-16T12:17:24Z

+1

Updates and code fixes applied according to the PR descriptions
Validation taken care of by the proponents
Jenkins tests pass

civanch · 2020-06-17T07:53:46Z

+1

cmsbuild · 2020-06-17T07:54:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-06-17T08:27:02Z

please test 23434.1001

silviodonato · 2020-06-17T09:33:52Z

please test workflow 23434.1001

cmsbuild · 2020-06-17T09:34:12Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 23434.1001
CMSSW_11_2_X_2020-06-16-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7131/console Started: 2020/06/17 11:43

cmsbuild · 2020-06-17T11:40:19Z

+1
Tested at: 35e006b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b516db/7131/summary.html
CMSSW: CMSSW_11_2_X_2020-06-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-17T11:40:22Z

Comparison job queued.

silviodonato · 2020-06-17T14:42:46Z

+1

cmsbuild · 2020-06-17T14:50:11Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b516db/7131/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778760
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

cmsbuild added this to the CMSSW_11_2_X milestone Jun 5, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Jun 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 5, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 6, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 6, 2020

cmsbuild added comparison-available code-checks-pending comparison-pending tests-pending and removed comparison-pending code-checks-approved comparison-available tests-approved labels Jun 6, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 16, 2020

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Jun 17, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jun 17, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 17, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 17, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 17, 2020

cmsbuild merged commit a2e8134 into cms-sw:master Jun 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 17, 2020

dildick deleted the from-CMSSW_11_2_X_2020-06-03-1100-LCT-CLCT-fractionalStrip branch June 17, 2020 20:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update accessor in CLCT and LCT data formats #30128

Update accessor in CLCT and LCT data formats #30128

dildick commented Jun 5, 2020 •

edited

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

civanch commented Jun 6, 2020

cmsbuild commented Jun 6, 2020 •

edited

cmsbuild commented Jun 6, 2020

cmsbuild commented Jun 6, 2020

cmsbuild commented Jun 6, 2020

cmsbuild commented Jun 7, 2020

perrotta commented Jun 16, 2020

civanch commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

silviodonato commented Jun 17, 2020

silviodonato commented Jun 17, 2020

cmsbuild commented Jun 17, 2020 •

edited

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

silviodonato commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

Update accessor in CLCT and LCT data formats #30128

Update accessor in CLCT and LCT data formats #30128

Conversation

dildick commented Jun 5, 2020 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

civanch commented Jun 6, 2020

cmsbuild commented Jun 6, 2020 • edited

cmsbuild commented Jun 6, 2020

cmsbuild commented Jun 6, 2020

cmsbuild commented Jun 6, 2020

cmsbuild commented Jun 7, 2020

perrotta commented Jun 16, 2020

civanch commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

silviodonato commented Jun 17, 2020

silviodonato commented Jun 17, 2020

cmsbuild commented Jun 17, 2020 • edited

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

silviodonato commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

dildick commented Jun 5, 2020 •

edited

cmsbuild commented Jun 6, 2020 •

edited

cmsbuild commented Jun 17, 2020 •

edited