Clean BuildFiles before DataFormats

[guitargeek]

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #29906), this time covering all subsystems before DataFormats.

Some plugins which were not merged with their header files actually had their header files in the interface directory, even though they are not needed by the library (only the plugins). This confuses my BuildFile/includes checker, which does not expect this entanglement between the library and the plugins. For these cases, I merged the plugin header with the cc file.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30139/15925

• This PR adds an extra 88KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiStripCommon/plugins/ShallowClustersProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File CalibTracker/SiStripHitEfficiency/src/HitEff.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
  • File DQM/SiOuterTracker/plugins/OuterTrackerMonitorTTTrack.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-for-range-copy #29927
  • File DQM/TrackingMonitorSource/plugins/StandaloneTrackMonitor.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

Alignment/APEEstimation
AnalysisAlgos/SiStripClusterInfoProducer
AnalysisAlgos/TrackInfoProducer
AnalysisDataFormats/EWK
AnalysisDataFormats/SUSYBSMObjects
AnalysisDataFormats/TopObjects
AnalysisDataFormats/TrackInfo
CalibTracker/SiStripCommon
CalibTracker/SiStripHitEfficiency
CaloOnlineTools/HcalOnlineDb
CommonTools/Clustering1D
CommonTools/MVAUtils
CommonTools/PileupAlgos
CommonTools/RecoAlgos
CommonTools/RecoUtils
CommonTools/Utils
CondCore/PopCon
CondCore/SiPixelPlugins
CondTools/DQM
Configuration/Skimming
DPGAnalysis/HcalTools
DPGAnalysis/SiStripTools
DPGAnalysis/Skims
DQM/SiOuterTracker
DQM/TrackingMonitorSource
DQMServices/Core
EgammaAnalysis/ElectronTools
ElectroWeakAnalysis/Utilities
ElectroWeakAnalysis/WENu
ElectroWeakAnalysis/WMuNu
ElectroWeakAnalysis/ZEE
ElectroWeakAnalysis/ZMuMu

@perrotta, @pgunnell, @andrius-k, @chayanit, @schneiml, @wajidalikhan, @tlampen, @christopheralanwest, @tocheng, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @slava77, @ggovi, @pohsun, @santocch can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @jainshilpi, @hatakeyamak, @robervalwalsh, @Martin-Grunewald, @fioriNTU, @abbiendi, @ebrondol, @venturia, @hdelanno, @makortel, @threus, @jhgoh, @varuns23, @jdolen, @dkotlins, @pieterdavid, @Sam-Harper, @barvic, @tocheng, @VinInn, @gkasieczka, @jandrea, @mschrode, @idebruyn, @mmusich, @mtosi, @fabiocos, @clelange, @adewit, @riga, @gbenelli, @ahinzmann, @mverzett, @sobhatta, @afiqaize this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6868/console Started: 2020/06/08 02:11

[cmsbuild]

+1
Tested at: 59fea5f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c8d54/6868/summary.html
CMSSW: CMSSW_11_2_X_2020-06-07-0000
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c8d54/6868/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780497
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780431
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[jfernan2]

+1

[santocch]

+1

[chayanit]

+1

[pohsun]

+1

[guitargeek]

Hi @pieterdavid, I'm a bit confused now because this PR got the alca-approved a few days ago even thought you were asking for it to be delayed. Does this mean that there is actually no problem and it should be merged, of was the signature just a misunderstanding? Thanks for any clarification.

[pieterdavid]

Hi @guitargeek thanks for checking, but there's no need to delay this (I brought it up because having it in last week's pre-release would have been convenient, but we will manage).

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30139/16173

• This PR adds an extra 92KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiStripCommon/plugins/ShallowClustersProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File CalibTracker/SiStripHitEfficiency/src/HitEff.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
  • File DQM/SiOuterTracker/plugins/OuterTrackerMonitorTTTrack.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-for-range-copy #29927
  • File DQM/TrackingMonitorSource/plugins/StandaloneTrackMonitor.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936

[silviodonato]

+1