added esConsumes to modules in EventFilter/RPCRawToDigi #30459

JamminJones · 2020-06-29T19:33:26Z

PR description:

added esConsumes to 4 modules

PR validation:

the code compiles

cmsbuild · 2020-06-29T19:33:52Z

The code-checks are being triggered in jenkins.

Dr15Jones · 2020-06-29T19:43:05Z

This change was made under my supervision.

Dr15Jones · 2020-06-29T19:45:59Z

EventFilter/RPCRawToDigi/plugins/RPCTwinMuxDigiToRaw.cc

@@ -29,7 +24,10 @@
 #include "EventFilter/RPCRawToDigi/interface/RPCTwinMuxRecord.h"

 RPCTwinMuxDigiToRaw::RPCTwinMuxDigiToRaw(edm::ParameterSet const& config)
-    : bx_min_(config.getParameter<int>("bxMin")),
+    : es_tm_link_map_br_token_(esConsumes<RPCAMCLinkMap, RPCTwinMuxLinkMapRcd>()),


This needs the 3rd template argument denoting this will be gotten in the BeginRun

cmsbuild · 2020-06-29T20:01:48Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-29T21:02:46Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30459/16595

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File EventFilter/RPCRawToDigi/plugins/RPCAMCUnpacker.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File EventFilter/RPCRawToDigi/plugins/RPCAMCUnpacker.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File EventFilter/RPCRawToDigi/plugins/RPCCPPFUnpacker.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/RPCRawToDigi/plugins/RPCTwinMuxDigiToRaw.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File EventFilter/RPCRawToDigi/src/RPCPackingModule.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30459/16595/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30459/16595/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-06-30T14:06:41Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-30T14:11:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30459/16626

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File EventFilter/RPCRawToDigi/plugins/RPCAMCUnpacker.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File EventFilter/RPCRawToDigi/plugins/RPCAMCUnpacker.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File EventFilter/RPCRawToDigi/plugins/RPCCPPFUnpacker.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/RPCRawToDigi/plugins/RPCTwinMuxDigiToRaw.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File EventFilter/RPCRawToDigi/src/RPCPackingModule.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936

cmsbuild · 2020-06-30T14:11:51Z

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

EventFilter/RPCRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2020-06-30T14:18:40Z

please test

cmsbuild · 2020-06-30T14:19:01Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7527/console Started: 2020/06/30 16:19

cmsbuild · 2020-06-30T15:33:21Z

+1
Tested at: d5eff6f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-366b00/7527/summary.html
CMSSW: CMSSW_11_2_X_2020-06-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-30T15:33:24Z

Comparison job queued.

cmsbuild · 2020-06-30T17:34:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-366b00/7527/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778915
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2778859
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
Checked 152 log files, 16 edm output root files, 36 DQM output files

slava77 · 2020-06-30T21:35:47Z

+1

for #30459 d5eff6f

code changes are in line with the PR description/title
- the static check points to RPCUnpackingModule still using es.get; I suppose this will be updated in a separate PR
jenkins tests pass and comparisons with the baseline show no (relevant differences)

cmsbuild · 2020-06-30T21:36:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-02T08:35:39Z

+1

added esConsumes to modules in EventFilter/RPCRawToDigi

2e36c37

cmsbuild added this to the CMSSW_11_2_X milestone Jun 29, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 29, 2020

Dr15Jones reviewed Jun 29, 2020

View reviewed changes

added BeginRun argument

2b84290

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 29, 2020

fixed clang format

d5eff6f

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 30, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 30, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 30, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 30, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jun 30, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 2, 2020

cmsbuild merged commit 85bafcd into cms-sw:master Jul 2, 2020

cmsbuild mentioned this pull request Jul 2, 2020

[DataFormats/PatCandidates] Rework statics in header file. #30499

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added esConsumes to modules in EventFilter/RPCRawToDigi #30459

added esConsumes to modules in EventFilter/RPCRawToDigi #30459

JamminJones commented Jun 29, 2020

cmsbuild commented Jun 29, 2020

Dr15Jones commented Jun 29, 2020

Dr15Jones Jun 29, 2020

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

Dr15Jones commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 •

edited

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

slava77 commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

silviodonato commented Jul 2, 2020

added esConsumes to modules in EventFilter/RPCRawToDigi #30459

added esConsumes to modules in EventFilter/RPCRawToDigi #30459

Conversation

JamminJones commented Jun 29, 2020

PR description:

PR validation:

cmsbuild commented Jun 29, 2020

Dr15Jones commented Jun 29, 2020

Dr15Jones Jun 29, 2020

Choose a reason for hiding this comment

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

Dr15Jones commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 • edited

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

slava77 commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

silviodonato commented Jul 2, 2020

cmsbuild commented Jun 30, 2020 •

edited