Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some function calls for fmt external as unittest #30518

Merged
merged 3 commits into from Jul 10, 2020
Merged

Add some function calls for fmt external as unittest #30518

merged 3 commits into from Jul 10, 2020

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jul 3, 2020 •
edited

PR description:

Adds a unit test for fmt external, see
cms-sw/cmsdist#6023

PR validation:

Builds and runs, prints whats expected in the .log file

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Jul 3, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30518/16730

  • This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30518/16733

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

FWCore/Utilities

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Jul 3, 2020

please test with cms-sw/cmsdist#6023

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6023

@cmsbuild cmsbuild mentioned this pull request Jul 3, 2020
Merged
makortel
makortel reviewed Jul 3, 2020
View reviewed changes
FWCore/Utilities/test/BuildFile.xml Outdated
<use name="cppunit"/>
<use name="fmt"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in FWcore/Utilities will have anything to do with fmt, so I'm not sure I want a dependence added here (even if it is in the tests). Perhaps FWCore/MessageService would be a better fit. @Dr15Jones, what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @makortel that this does not belong here as we do not want to add unnecessary dependencies. I think it would be best to add to FWCore/MessageLogger since that is where I think we will first make use of it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr15Jones , @makortel , this is just for testing the tool itself. We can add it under Utilities/General/test

Copy link
Contributor Author

@mrodozov mrodozov Jul 3, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr15Jones , @makortel , this is just for testing the tool itself. We can add it under Utilities/General/test

I moved it to Utilities/General/test if we want it in FWCore/MessageLogger I'll move it again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested FWCore/MessageService because that's we seem to have all MessageLogger related tests (and FWCore/MessageLogger does not have test subdirectory).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved in FWCore/MessageService

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

+1
Tested at: 04a1c97
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0bb97/7649/summary.html
CMSSW: CMSSW_11_2_X_2020-07-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

The code-checks are being triggered in jenkins.

@mrodozov
Copy link
Contributor Author

mrodozov commented Jul 8, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30518/16864

  • This PR adds an extra 24KB to repository

  • Found files with invalid states:

    • FWCore/Utilities/test/fmt_test.cppunit.cpp:
    • Utilities/General/test/fmt_test.cppunit.cpp:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

Pull request #30518 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

+1
Tested at: 4b45672
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f164c/7814/summary.html
CMSSW: CMSSW_11_2_X_2020-07-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f164c/7814/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787364
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787313
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@makortel
Copy link
Contributor

makortel commented Jul 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 312ec7f into cms-sw:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel left review comments

@Dr15Jones Dr15Jones Dr15Jones left review comments

@smuzaffar smuzaffar smuzaffar left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mrodozov @cmsbuild @makortel @silviodonato @Dr15Jones @smuzaffar