Minimal cleanup of PFClusterValidation code #30589

fwyzard · 2020-07-08T07:49:08Z

Minimal clean up of the PFClusterValidation module, addressing various issues:

unsafe assumptions that could potentially "leak" information across events;
use of common functions instead of private redefinitions;
adherence to CMS coding rules.

fwyzard · 2020-07-08T07:49:28Z

Fixes #30588 .

cmsbuild · 2020-07-08T07:49:39Z

The code-checks are being triggered in jenkins.

fwyzard · 2020-07-08T07:49:42Z

@cmsbuild, please test

cmsbuild · 2020-07-08T07:54:25Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30589/16839

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Validation/RecoParticleFlow/plugins/PFClusterValidation.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Validation/RecoParticleFlow/plugins/PFClusterValidation.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30589/16839/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30589/16839/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

fwyzard · 2020-07-08T08:13:15Z

@cmsbuild, please test

cmsbuild · 2020-07-08T08:13:31Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-08T08:18:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30589/16841

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Validation/RecoParticleFlow/plugins/PFClusterValidation.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Validation/RecoParticleFlow/plugins/PFClusterValidation.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

cmsbuild · 2020-07-08T08:18:26Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-07-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7775/console Started: 2020/07/08 10:46

cmsbuild · 2020-07-08T08:18:27Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

Validation/RecoParticleFlow

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-07-08T10:04:08Z

+1
Tested at: 85f95dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-beced4/7775/summary.html
CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-08T10:04:11Z

Comparison job queued.

cmsbuild · 2020-07-08T14:28:09Z

The code-checks are being triggered in jenkins.

fwyzard · 2020-07-08T14:28:21Z

Thanks for the comments @Dr15Jones , they should all be addressed in the last commit.

fwyzard · 2020-07-08T14:29:40Z

@cmsbuild, please test

cmsbuild · 2020-07-08T14:37:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30589/16850

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Validation/RecoParticleFlow/plugins/PFClusterValidation.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Validation/RecoParticleFlow/plugins/PFClusterValidation.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

cmsbuild · 2020-07-08T14:37:40Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-07-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7781/console Started: 2020/07/08 16:43

cmsbuild · 2020-07-08T14:37:41Z

Pull request #30589 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

cmsbuild · 2020-07-08T16:07:28Z

+1
Tested at: 32a4250
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-beced4/7781/summary.html
CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-08T16:07:31Z

Comparison job queued.

cmsbuild · 2020-07-08T17:55:30Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-beced4/7781/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2787364
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2787307
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

jfernan2 · 2020-07-09T09:24:19Z

+1

cmsbuild · 2020-07-09T09:24:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-10T08:09:02Z

+1

Minimal clean up of the PFClusterValidation module, addressing various issues: - unsafe assumptions that could potentially "leak" information across events; - use of common functions instead of private redefinitions; - adherence to CMS coding rules; - make better use of const/constexpr variables.

cmsbuild added this to the CMSSW_11_2_X milestone Jul 8, 2020

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jul 8, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 8, 2020

Minimal cleanup of PFClusterValidation code

85f95dc

fwyzard force-pushed the cleanup_PFClusterValidation branch from d90093b to 85f95dc Compare July 8, 2020 08:13

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 8, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 8, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 8, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 8, 2020

cmsbuild added the tests-pending label Jul 8, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 8, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 8, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 8, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 8, 2020

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 9, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 10, 2020

cmsbuild merged commit afa7ab7 into cms-sw:master Jul 10, 2020

fwyzard deleted the cleanup_PFClusterValidation branch July 10, 2020 11:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minimal cleanup of PFClusterValidation code #30589

Minimal cleanup of PFClusterValidation code #30589

fwyzard commented Jul 8, 2020

fwyzard commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

fwyzard commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

fwyzard commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020 •

edited

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

fwyzard commented Jul 8, 2020

fwyzard commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020 •

edited

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

jfernan2 commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

silviodonato commented Jul 10, 2020

Minimal cleanup of PFClusterValidation code #30589

Minimal cleanup of PFClusterValidation code #30589

Conversation

fwyzard commented Jul 8, 2020

fwyzard commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

fwyzard commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

fwyzard commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020 • edited

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

fwyzard commented Jul 8, 2020

fwyzard commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020 • edited

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

jfernan2 commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

silviodonato commented Jul 10, 2020

cmsbuild commented Jul 8, 2020 •

edited

cmsbuild commented Jul 8, 2020 •

edited