CSJet update for fastjet-contrib 1.044

[mseidel42]

PR description:

Update of fastjet-contrib required by new Rivet plugins, see cms-sw/cmsdist#6028

Adapt for small change of ConstituentSubtractor::set_do_mass_subtraction()

  void ConstituentSubtractor::set_do_mass_subtraction(bool do_mass_subtraction){
    _do_mass_subtraction=do_mass_subtraction;
  }

to

  void ConstituentSubtractor::set_do_mass_subtraction(){
    _do_mass_subtraction=true;
    _masses_to_zero=false;
  }

Needs to be tested with cms-sw/cmsdist#6028

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30590/16840

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoJets/JetProducers/plugins/CSJetProducer.cc modified in PR(s): Flow modulated CS subtraction for heavy ions #30057

[cmsbuild]

A new Pull Request was created by @intrepid42 (Markus Seidel) for master.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @jdamgov, @yslai, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

test parameters:

• pull_request = Update to Rivet 3.1.2 and Yoda 1.8.3 cmsdist#6028

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6028

• CMSSW_11_2_X_2020-07-07-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7774/console Started: 2020/07/08 10:18

[cmsbuild]

-1

Tested at: 9556525

CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1c76e/7774/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

• Unit Tests:

I found errors in the following unit tests:

---> test test-rivet-run had ERRORS

• RelVals:

When I ran the RelVals I found an error in the following workflows:
25202.0 step5

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[slava77]

the error in 25202.0 step5 is

Rivet.Analysis.HiggsTemplateCrossSections: WARN  Unkown Higgs production mechanism. Cannot classify event. Classification for all events will most likely fail.
Rivet.AnalysisHandler: INFO  Using named weights
Error in RivetAnalysis::init method: No projections registered for parent 0x2b0fcd18a900

not quite obviously, but seems related to the externals added in the test

[cmsbuild]

Pull request #30590 was updated. @SiewYan, @perrotta, @mkirsano, @cmsbuild, @jpata, @agrohsje, @slava77, @alberto-sanchez, @qliphy, @GurpreetSinghChahal can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6028

• CMSSW_11_2_X_2020-07-08-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7823/console Started: 2020/07/09 14:46

[cmsbuild]

+1
Tested at: 2ab3c30
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1c76e/7823/summary.html
CMSSW: CMSSW_11_2_X_2020-07-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1c76e/7823/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2787364
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2787313
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[perrotta]

+1

• Technical for reco (true is the default input value for set_do_mass_subtraction() )
• Jenkins tests pass

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1