Phase2-hgx253 Fix error reported from static analyzer #30623

bsunanda · 2020-07-09T18:07:29Z

PR description:

Fix error reported from static analyzer

PR validation:

Tested using runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2020-07-09T18:07:54Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-09T18:19:02Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30623/16886

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/src/HGCalDDDConstants.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30623/16886/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30623/16886/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-07-09T18:35:21Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-09T18:44:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30623/16888

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/src/HGCalDDDConstants.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935

cmsbuild · 2020-07-09T18:45:15Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2020-07-09T19:05:50Z

@cmsbuild Please test

cmsbuild · 2020-07-09T19:06:11Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-09-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7833/console Started: 2020/07/09 21:23

cmsbuild · 2020-07-09T20:36:40Z

+1
Tested at: 66c629a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b4526/7833/summary.html
CMSSW: CMSSW_11_2_X_2020-07-09-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-09T20:36:43Z

Comparison job queued.

cvuosalo · 2020-07-09T21:48:38Z

Geometry/HGCalCommonData/src/HGCalDDDConstants.cc

  if (fromFile && (waferFileSize() > 0)) {
    auto itr = hgpar_->waferInfoMap_.find(wl);
-    if (itr != hgpar_->waferInfoMap_.end()) {
+    endOfList = (itr != hgpar_->waferInfoMap_.end());


Am I reading this line correctly? endOfList is true if the end of the list has NOT been reached? Isn't that backwards? Am I missing something?

cmsbuild · 2020-07-09T22:04:13Z

Pull request #30623 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

bsunanda · 2020-07-09T22:05:04Z

@cmsbuild Please test

cmsbuild · 2020-07-09T22:05:29Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-09-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7837/console Started: 2020/07/10 00:05

cmsbuild · 2020-07-09T22:28:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b4526/7833/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2787429
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2787378
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

cmsbuild · 2020-07-09T23:20:05Z

+1
Tested at: aad2eae
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b4526/7837/summary.html
CMSSW: CMSSW_11_2_X_2020-07-09-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-09T23:20:07Z

Comparison job queued.

cmsbuild · 2020-07-10T01:15:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b4526/7837/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2787429
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2787378
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

cvuosalo · 2020-07-10T17:24:30Z

+1

kpedro88 · 2020-07-10T17:49:09Z

+upgrade

cmsbuild · 2020-07-10T17:49:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-11T07:12:18Z

+1

Fix error reported from static analyzer

27e1a85

cmsbuild added this to the CMSSW_11_2_X milestone Jul 9, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jul 9, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 9, 2020

Code check

66c629a

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 9, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 9, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 9, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 9, 2020

cvuosalo reviewed Jul 9, 2020

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Jul 9, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 9, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Jul 9, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 10, 2020

cmsbuild added geometry-approved and removed geometry-pending labels Jul 10, 2020

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Jul 10, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 11, 2020

cmsbuild merged commit 9f6ad8e into cms-sw:master Jul 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx253 Fix error reported from static analyzer #30623

Phase2-hgx253 Fix error reported from static analyzer #30623

bsunanda commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

bsunanda commented Jul 9, 2020

cmsbuild commented Jul 9, 2020 •

edited

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cvuosalo Jul 9, 2020

cmsbuild commented Jul 9, 2020

bsunanda commented Jul 9, 2020

cmsbuild commented Jul 9, 2020 •

edited

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 10, 2020

cvuosalo commented Jul 10, 2020

kpedro88 commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

silviodonato commented Jul 11, 2020

Phase2-hgx253 Fix error reported from static analyzer #30623

Phase2-hgx253 Fix error reported from static analyzer #30623

Conversation

bsunanda commented Jul 9, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

bsunanda commented Jul 9, 2020

cmsbuild commented Jul 9, 2020 • edited

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cvuosalo Jul 9, 2020

Choose a reason for hiding this comment

cmsbuild commented Jul 9, 2020

bsunanda commented Jul 9, 2020

cmsbuild commented Jul 9, 2020 • edited

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 10, 2020

cvuosalo commented Jul 10, 2020

kpedro88 commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

silviodonato commented Jul 11, 2020

cmsbuild commented Jul 9, 2020 •

edited

cmsbuild commented Jul 9, 2020 •

edited