Add support of printf()-like formatting to MessageLogger

[fwyzard]

PR description:

Following the discussion in #30463 this PR implements printf-style formatting for the MessageLogger objects.
The syntax is, for example: edm::LogInfo(category).printf(format, ...).

The implementation reuses the {fmt} library introduced in #30626.

PR validation:

Unit tests run and pass.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30629/16897

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/MessageLogger/BuildFile.xml modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageLogger/interface/ErrorObj.h modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageLogger/interface/ErrorObj.icc modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageLogger/interface/MessageLogger.h modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageLogger/interface/MessageSender.h modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageService/test/UnitTestClient_C.cc modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageService/test/unit_test_outputs/u10_warnings.log modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageService/test/unit_test_outputs/u6_warnings.log modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30629/16897/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30629/16897/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[fwyzard]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30629/16898

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/MessageLogger/BuildFile.xml modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageLogger/interface/ErrorObj.h modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageLogger/interface/ErrorObj.icc modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageLogger/interface/MessageLogger.h modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageLogger/interface/MessageSender.h modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageService/test/UnitTestClient_C.cc modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageService/test/unit_test_outputs/u10_warnings.log modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626
  • File FWCore/MessageService/test/unit_test_outputs/u6_warnings.log modified in PR(s): Add support of std::format()-like formatting to MessageLogger #30626

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-09-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7846/console Started: 2020/07/10 11:53

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

FWCore/MessageLogger
FWCore/MessageService

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[makortel]

MessageLogger has always used the formatting encouraged by C++ standard. The future standard is encouraging std::format(). Of course people are free to use fmt::sprintf(), although that would make it less straightforward to eventually remove {fmt} when std::format() becomes supported by all std implementations we use (at that time).

[fwyzard]

That doesn't mean that people shouldn't be given the freedom to use the formatting they are more comfortable with - see all the uses of sprintf and boost::format vs nobody asking for std::format-like capabilities.

[cmsbuild]

-1

Tested at: 58a3ab1

CMSSW: CMSSW_11_2_X_2020-07-09-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d40a14/7846/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreServicesDriver had ERRORS

[qliphy]

Summary of the discussion at the Core Software meeting: "we just don't want to support this, independently of any technical or implementation issue".

closing this PR now. Please open a new one if needed.

[fwyzard]

Moved to #37244 and #37245 .