Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain only RAW data collections in DQM/Integration unit test setup #30686

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 14, 2020

PR description:

As discussed with core DQM team, this change makes the DQM/Integration test setup for online clients slightly more realistic as it drops all the RECO level unpacked collections from the input FEVT data-tier, making it more similar to the input streamer files which are used in live production mode.

PR validation:

$ scramv1 b runtests > & log.log & 
$ more log.log | grep 'client succeeded'
---> test TestDQMOnlineClient-scal_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-dt4ml_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-info_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-hcal_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-hlt_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-sistrip_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-hcalreco_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-l1tstage2_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-csc_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-castor_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-l1tstage2emulator_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-mutracking_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-beampixel_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-dt_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-beam_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-es_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-pixel_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-pixellumi_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-ctpps_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-ecal_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-gem_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-rpc_dqm_sourceclient succeeded
---> test TestDQMOnlineClient-fed_dqm_sourceclient succeeded

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport - no backport is intended for the moment, though it can done if needed.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 14, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30686/16976

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

DQM/Integration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 7f59c91
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e53609/7935/summary.html
CMSSW: CMSSW_11_2_X_2020-07-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e53609/7935/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787429
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2787373
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@schneiml
Copy link
Contributor

Nice, thanks @mmusich!

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fae3446 into cms-sw:master Jul 15, 2020
@mrodozov
Copy link
Contributor

this unit test:

TestDQMOnlineClient-gem_dqm_sourceclient
is consistently failing in the Arm IB. It looks like it is on file close. See
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_aarch64_gcc820/CMSSW_11_2_X_2020-09-15-1100/unitTestLogs/DQM/Integration#/137-137
and then the default ib:
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_2_X_2020-09-14-2300/unitTestLogs/DQM/Integration#/1957-1957

so I'll open an issue on it in the morning

@mmusich mmusich deleted the makeDQMIntegrationTestMoreRealistic branch September 16, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants