Added refToPSet_ ability in python PSet

[Dr15Jones]

The python PSet class is now capable of containing a lazy evaluated reference to a PSet at the highest level of the Process. This is done by using a parameter named refToPSet_ which takes a cms.string with the label of the top level PSet to which one wants to reference. The reference does not happen until we convert the python PSet into the C++ ParameterSet. At that time a copy to the reference is used to create the C++ ParameterSet.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Added refToPSet_ ability in python PSet

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

@rovere @makortel

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[cmsbuild]

-1
I ran the usual tests and I found errors in the following unit tests:

---> test unitTestsGroup_3 had ERRORS
---> test unitTestsLimits had ERRORS
---> test unitTestsGroup_5 had ERRORS
---> test testLoggerInCmsRun had ERRORS
---> test unitTestsGroup_4 had ERRORS
---> test unitTestsGroup_d had ERRORS
---> test unitTestsStatistics had ERRORS
---> test unitTestsGroup_1 had ERRORS
---> test unitTestsGroup_6 had ERRORS
---> test unitTestsGroup_2 had ERRORS
---> test TestFWCoreModulesContent had ERRORS
---> test TestFWCoreFrameworkESProducerLooper had ERRORS
---> test TestFWCoreFrameworkReplace had ERRORS
---> test TestFWCoreFrameworkGlobalStreamOne had ERRORS
---> test TestFWCoreFrameworkESRefer had ERRORS
---> test TestFWCoreFrameworkTrigMask had ERRORS
---> test TestFWCoreFrameworkDeleteEarly had ERRORS
---> test TestFWCoreFrameworkUnscheduled had ERRORS
---> test TestFWCoreFrameworkInputTagFailure had ERRORS
---> test TestFWCoreFrameworkTBBTasks had ERRORS
---> test TestFWCoreFrameworkeventprocessor had ERRORS
---> test TestFWCoreFramework had ERRORS
---> test TestFWCoreFrameworkTrigBit had ERRORS
---> test TestIntegrationEventHistory had ERRORS
---> test CatchStdExceptiontest had ERRORS
---> test TestIntegrationServiceExample had ERRORS
---> test TestIntegrationRefMerge had ERRORS
---> test TestSubProcess had ERRORS
---> test TestIntegrationParentless had ERRORS
---> test TestIntegrationParameterSet had ERRORS
---> test TestIntegrationEventSetup had ERRORS
---> test TestIntegrationTransRef had ERRORS
---> test TestIntegrationUnscheduledFailOnOutput had ERRORS
---> test CatchCmsExceptiontest had ERRORS
---> test TestIntegrationExternalSource had ERRORS
---> test TestIntegrationSeriesOfProcesses had ERRORS
---> test TestIntegrationRunMerge had ERRORS
---> test TestIntegrationGetBy had ERRORS
---> test TestIntegrationHierarchyExample had ERRORS
---> test TestIntegrationView had ERRORS
---> test TestIntegrationRef had ERRORS
---> test TestFWCoreIntegrationStandalone had ERRORS
---> test TestIntegrationProducedSource had ERRORS
---> test TestFWCoreServicesDriver had ERRORS
---> test TestDQMServicesFwkIOScripts had ERRORS
---> test testCSCTFRawToDigi had ERRORS
---> test GeometryCommonTopologiesTestDriver had ERRORS
---> test HcalGeometryTest had ERRORS
---> test runtestTqafTopSkimming had ERRORS
---> test runtestTqafTopTools had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafTopHitFit had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafExamples had ERRORS
---> test TestIOMCRandomEngineService had ERRORS
---> test runtestUtilAlgos had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test TestDriver had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3072/707/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

[Dr15Jones]

@nclopezo Please retest

[cmsbuild]

Pull request #3072 was updated. @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

[Dr15Jones]

+1
If the tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[ktf]

So I ran the tests but cmsbuild did not bother publishing results. Not sure why. @nclopezo can you check what happened? In any case there seems to be issues (not sure if related):

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3072/707/

[Dr15Jones]

Are you sure you got the latest version after I did 'git commit --amend' and forced the changes to the remote branch? I ask since I thought I had run the framework unit tests and they all passed, but in your test they are failing.

[Dr15Jones]

@ktf I double checked and rebuild my area from scratch and all the Framework unit tests passed. Definitely before I did the 'git commit --amend' the error you see was there but with the updated code which is in the repository I don't see it anymore.

[nclopezo]

@ktf
Hi,

The url in your last comment #3072 (comment) is the same that cmsbuild published last Friday #3072 (comment)

I don't see any run for the tests of this pull request done yesterday in the Jenkins build history:
https://cmssdt.cern.ch/jenkins/job/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/

Anyway, I started the tests for this pr.

[makortel]

Thanks Chris!

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3072/712/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?