Migrate DQM from boost::format to {fmt} #30857

fwyzard · 2020-07-21T17:36:09Z

PR description:

Migrate from boost::format to fmt::sprintf.

cmsbuild · 2020-07-21T17:36:28Z

The code-checks are being triggered in jenkins.

fwyzard · 2020-07-21T17:42:53Z

Just a suggestion, now that {fmt} is available in CMSSW.

fwyzard · 2020-07-21T17:43:35Z

@cmsbuild, please test

cmsbuild · 2020-07-21T17:43:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30857/17214

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMServices/FileIO/plugins/DQMFileSaverPB.cc modified in PR(s): Added new DQM GUI support to all Online DQM clients #30592
- File DQMServices/StreamerIO/plugins/DQMFileIterator.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/JsonWritingTimeoutPoolOutputModule.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/RamdiskMonitor.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/test/DQMStreamerOutputRepackerTest.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/test/DQMStreamerWriteJsonAnalyzer.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811

cmsbuild · 2020-07-21T17:43:56Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-21-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8194/console Started: 2020/07/21 19:46

cmsbuild · 2020-07-21T17:43:58Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

DQM/HLTEvF
DQMServices/FileIO
DQMServices/StreamerIO

@Martin-Grunewald, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @fwyzard can you please review it and eventually sign? Thanks.
@mtosi, @missirol, @barvic this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-07-21T18:54:51Z

-1

Tested at: 879d59b

CMSSW: CMSSW_11_2_X_2020-07-21-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23e0cd/8194/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test DQMServicesStreamerIORunStreamer had ERRORS

cmsbuild · 2020-07-21T18:54:53Z

Comparison job queued.

cmsbuild · 2020-07-21T21:00:21Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23e0cd/8194/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525996
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2525943
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 33 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
Checked 144 log files, 17 edm output root files, 34 DQM output files

silviodonato · 2020-07-24T13:10:37Z

please test

cmsbuild · 2020-07-24T13:11:16Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8271/console Started: 2020/07/24 15:12

cmsbuild · 2020-08-04T11:48:53Z

The code-checks are being triggered in jenkins.

fwyzard · 2020-08-04T11:49:36Z

@cmsbuild, please test

cmsbuild · 2020-08-04T11:54:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30857/17544

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMServices/FileIO/plugins/DQMFileSaverPB.cc modified in PR(s): Added new DQM GUI support to all Online DQM clients #30592

cmsbuild · 2020-08-04T11:55:13Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-03-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8548/console Started: 2020/08/04 14:08

cmsbuild · 2020-08-04T11:55:14Z

Pull request #30857 was updated. @Martin-Grunewald, @andrius-k, @kmaeshima, @cmsbuild, @jfernan2, @fioriNTU, @fwyzard can you please check and sign again.

cmsbuild · 2020-08-04T13:31:50Z

+1
Tested at: 286e3f3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23e0cd/8548/summary.html
CMSSW: CMSSW_11_2_X_2020-08-03-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Minor updates to Sonic (Core and Triton) #31016 @kpedro88: Minor updates to Sonic (Core and Triton)
Modernize modules in Calibration/HcalAlCaRecoProducers #30983 @Dr15Jones: Modernize modules in Calibration/HcalAlCaRecoProducers

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23e0cd/8548/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23e0cd/8548/git-merge-result

cmsbuild · 2020-08-04T13:31:52Z

Comparison job queued.

fwyzard · 2020-08-04T14:44:11Z

+1

cmsbuild · 2020-08-04T14:57:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23e0cd/8548/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525448
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2525394
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

jfernan2 · 2020-08-04T21:33:01Z

+1

cmsbuild · 2020-08-04T21:33:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-08-05T07:42:34Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Jul 21, 2020

cmsbuild added code-checks-pending comparison-pending dqm-pending hlt-pending orp-pending pending-signatures tests-pending labels Jul 21, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 21, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 21, 2020

cmsbuild added tests-rejected and removed tests-started labels Jul 21, 2020

cmsbuild mentioned this pull request Jul 21, 2020

Move DQMServices/StreamerIO to std::filesystem #30811

Merged

cmsbuild added comparison-available and removed comparison-pending labels Jul 21, 2020

cmsbuild removed comparison-available tests-rejected labels Jul 24, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 4, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 4, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 4, 2020

cmsbuild added hlt-approved and removed hlt-pending labels Aug 4, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 4, 2020

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Aug 4, 2020

cmsbuild added orp-approved and removed orp-pending labels Aug 5, 2020

cmsbuild merged commit 8cdb296 into cms-sw:master Aug 5, 2020

fwyzard deleted the migrate_boost_format_to_fmt_DQM branch August 18, 2021 13:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate DQM from boost::format to {fmt} #30857

Migrate DQM from boost::format to {fmt} #30857

fwyzard commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

fwyzard commented Jul 21, 2020

fwyzard commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020 •

edited

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

silviodonato commented Jul 24, 2020

cmsbuild commented Jul 24, 2020 •

edited

cmsbuild commented Aug 4, 2020

fwyzard commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020 •

edited

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

fwyzard commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

jfernan2 commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

silviodonato commented Aug 5, 2020

Migrate DQM from boost::format to {fmt} #30857

Migrate DQM from boost::format to {fmt} #30857

Conversation

fwyzard commented Jul 21, 2020

PR description:

cmsbuild commented Jul 21, 2020

fwyzard commented Jul 21, 2020

fwyzard commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020 • edited

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

silviodonato commented Jul 24, 2020

cmsbuild commented Jul 24, 2020 • edited

cmsbuild commented Aug 4, 2020

fwyzard commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020 • edited

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

fwyzard commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

jfernan2 commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

silviodonato commented Aug 5, 2020

cmsbuild commented Jul 21, 2020 •

edited

cmsbuild commented Jul 24, 2020 •

edited

cmsbuild commented Aug 4, 2020 •

edited