improved printouts and G4 destruction #30887

civanch · 2020-07-23T16:12:18Z

PR description:

Several misprints and improvements are added, which are useful for debugging.

From destructors of Geant4 interface classes removed operations to destruct Geant4 - this should be performed in endRun methods called by the Framework. Should address #30863.

This PR should not affect any result.

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport that PR:

no backport expected

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-07-23T16:12:46Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-23T16:17:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30887/17270

This PR adds an extra 48KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimG4CMS/Calo/src/ECalSD.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4CMS/Calo/src/HCalSD.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/Application/plugins/OscarMTProducer.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/Application/src/RunManagerMT.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/Application/src/RunManagerMTWorker.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EMM.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EMN.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EMV.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EMZ.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT_EMN.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT_EMV.cc modified in PR(s): Improved info printouts for simulation #30652

cmsbuild · 2020-07-23T16:18:21Z

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4CMS/Calo
SimG4Core/Application
SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

civanch · 2020-07-23T16:22:03Z

please test

cmsbuild · 2020-07-23T16:22:26Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-23-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8250/console Started: 2020/07/23 18:23

cmsbuild · 2020-07-23T17:29:45Z

+1
Tested at: bf9e49c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49886a/8250/summary.html
CMSSW: CMSSW_11_2_X_2020-07-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-23T17:29:47Z

Comparison job queued.

cmsbuild · 2020-07-23T21:14:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49886a/8250/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 37887 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2526188
DQMHistoTests: Total failures: 347090
DQMHistoTests: Total nulls: 9
DQMHistoTests: Total successes: 2179042
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.226 KiB( 33 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.596 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.590 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.838 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -2.890 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 8.0 ): 4.688 KiB SiStrip/MechanicalView
Checked 144 log files, 17 edm output root files, 34 DQM output files

cmsbuild · 2020-07-24T09:35:57Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-24T09:42:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30887/17283

This PR adds an extra 52KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimG4CMS/Calo/src/ECalSD.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4CMS/Calo/src/HCalSD.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/Application/plugins/OscarMTProducer.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/Application/src/RunManagerMT.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/Application/src/RunManagerMTWorker.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/Generators/src/Generator.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EMM.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EMN.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EMV.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EMZ.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT_EMN.cc modified in PR(s): Improved info printouts for simulation #30652
- File SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT_EMV.cc modified in PR(s): Improved info printouts for simulation #30652

cmsbuild · 2020-07-24T09:42:44Z

Pull request #30887 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

civanch · 2020-07-24T10:00:38Z

please test

cmsbuild · 2020-07-24T10:00:57Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8265/console Started: 2020/07/24 12:01

cmsbuild · 2020-07-24T11:08:32Z

+1
Tested at: 5f51a8e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49886a/8265/summary.html
CMSSW: CMSSW_11_2_X_2020-07-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-24T11:08:35Z

Comparison job queued.

cmsbuild · 2020-07-24T12:32:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49886a/8265/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2526188
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2526140
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

civanch · 2020-07-24T15:09:22Z

+1

cmsbuild · 2020-07-24T15:09:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-25T07:32:35Z

+1

civanch added 2 commits July 23, 2020 17:56

improved printouts and G4 destruction

325db1a

code format

bf9e49c

cmsbuild added this to the CMSSW_11_2_X milestone Jul 23, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Jul 23, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 23, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 23, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 23, 2020

civanch mentioned this pull request Jul 23, 2020

Segfault on file close in materialBudgetTrackerPlots test #30863

Closed

cmsbuild added comparison-available and removed comparison-pending labels Jul 23, 2020

do not use extra random numbers

4b82b51

cmsbuild removed code-checks-approved comparison-available tests-approved labels Jul 24, 2020

cmsbuild added code-checks-pending and removed code-checks-approved labels Jul 24, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 24, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 24, 2020

civanch mentioned this pull request Jul 24, 2020

Improved info printouts for simulation #30652

Closed

silviodonato mentioned this pull request Jul 24, 2020

Integrating PPS full sim in Run3 (only) #30575

Merged

cmsbuild added tests-approved and removed tests-started labels Jul 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 24, 2020

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Jul 24, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 25, 2020

cmsbuild merged commit 2f1aef0 into cms-sw:master Jul 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improved printouts and G4 destruction #30887

improved printouts and G4 destruction #30887

civanch commented Jul 23, 2020 •

edited

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

civanch commented Jul 23, 2020

cmsbuild commented Jul 23, 2020 •

edited

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

civanch commented Jul 24, 2020

cmsbuild commented Jul 24, 2020 •

edited

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

civanch commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

silviodonato commented Jul 25, 2020

improved printouts and G4 destruction #30887

improved printouts and G4 destruction #30887

Conversation

civanch commented Jul 23, 2020 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

civanch commented Jul 23, 2020

cmsbuild commented Jul 23, 2020 • edited

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

civanch commented Jul 24, 2020

cmsbuild commented Jul 24, 2020 • edited

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

civanch commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

silviodonato commented Jul 25, 2020

civanch commented Jul 23, 2020 •

edited

cmsbuild commented Jul 23, 2020 •

edited

cmsbuild commented Jul 24, 2020 •

edited