Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PPS records for 2018 and Run-3 #30890

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR is a technical update to include three PPS tags in 2018 and Run-3 GTs:

  • CTPPSPixelAnalysisMask_v1_mc
  • CTPPSPixelDAQMapping_v1_mc
  • CTPPSPixelGainCalibrations_v1_mc

For 2018 GTs, this replaces the same tags but without the "_v1" string in the tag name. For Run-3 GTs, no CTPPSPixelAnalysisMaskRcd, CTPPSPixelDAQMappingRcd or CTPPSPixelGainCalibrationsRcd records were previously present in the GT. The absence of these records causes spurious issues when testing PPS simulation pull requests.

In addition, an obsolete unlabeled SiPixel2DTemplateDBObjectRcd is removed from the auto:phase1_2018_realistic_hi GT.

No changes are expected in any workflow as the PPS simulation is not yet present.

The GT diffs are as follows:

2018 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_upgrade2018_design_v1/112X_upgrade2018_design_v1

2018 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_v1/112X_upgrade2018_realistic_v2

2018 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_HI_v5/112X_upgrade2018_realistic_HI_v1

2018 realistic (HE fail)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HEfail_v1/112X_upgrade2018_realistic_HEfail_v2

2018 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_deco_v1/112X_upgrade2018cosmics_realistic_deco_v2

2018 cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_peak_v1/112X_upgrade2018cosmics_realistic_peak_v2

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_design_v3/112X_mcRun3_2021_design_v4

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_v3/112X_mcRun3_2021_realistic_v4

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021cosmics_realistic_deco_v3/112X_mcRun3_2021cosmics_realistic_deco_v4

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_HI_v3/112X_mcRun3_2021_realistic_HI_v4

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2023_realistic_v3/112X_mcRun3_2023_realistic_v4

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2024_realistic_v3/112X_mcRun3_2024_realistic_v4

PR validation:

The new PPS payloads have already been used in the offline data GT since 2018.

In addition, a technical test was performed:

runTheMatrix.py -l limited,12024.0,7.23,159.0,12834.0,11224.0,11024.2,7.4 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and should not be backported.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 12024.0,7.23,159.0,12834.0,11224.0,11024.2,7.4

@christopheralanwest
Copy link
Contributor Author

Attn: @malbouis @mundim

Please check that everything is as expected.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30890/17276

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 23, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: cc43f5f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c029a/8255/summary.html
CMSSW: CMSSW_11_2_X_2020-07-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c029a/8255/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2c029a/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2c029a/11224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018Design_GenSimFull+DigiFull_2018Design+RecoFull_2018Design+HARVESTFull_2018Design
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2c029a/12024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021Design_GenSimFull+DigiFull_2021Design+RecoFull_2021Design+HARVESTFull_2021Design
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2c029a/159.0_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RECOHI2021PPRECO+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2c029a/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2526188
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2526140
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • No changes in any comparison tests, as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants