Fix break condition

[steggema]

PR description:

Addresses invalid memory write in DeepMETProducer described here #30920 and implements trivial fix described therein.

PR validation:

Tested matrix workflow 140.5611 (2018 heavy-ion data) before fix (failed) and after fix (passed).

if this PR is a backport please specify the original PR and why you need to backport that PR:

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30926/17329

• This PR adds an extra 12KB to repository

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-27-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8316/console Started: 2020/07/27 17:18

[cmsbuild]

A new Pull Request was created by @steggema (Jan Steggemann) for master.

It involves the following packages:

RecoMET/METPUSubtraction

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @ahinzmann, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: b1eee14
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e66833/8316/summary.html
CMSSW: CMSSW_11_2_X_2020-07-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e66833/8316/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525444
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2525385
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 33 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[slava77]

+1

for #30926 b1eee14

• code changes are in line with the PR description and the preceding discussion in Invalid memory write in DeepMETProducer #30920
  • the run-time issue was tested with ASAN according to the PR description
• jenkins tests pass and comparisons with the baseline show no (relevant) differences
  • some differences in slimmedTaus are unrelated and should go away after fix index typo in PFRecoTauClusterVariables #30919

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1